Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

From	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig
Date	2016-07-21 14:50 +0200
Message-ID	<rXlAl-7uo-15@gated-at.bofh.it> (permalink)
References	<rXlAl-7uo-3@gated-at.bofh.it> <rXlAl-7uo-17@gated-at.bofh.it> <rXlAl-7uo-19@gated-at.bofh.it>
Organization	Free Electrons

Show all headers | View raw

Hello,

On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote:
> > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>  
> 
> Why?  It's not like this is an on-soc device, but most likely a PCIe card.
> Should we build-in all PCIe drivers?

I agree.

> I think it makes more sense to have this as a module rather than built-in.

I would prefer to not have it all in the defconfig. I'd hate to have
a defconfig that builds tons of random modules "just because".

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-07-21 14:50 +0200
  Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig Grzegorz Jaszczyk <jaz@semihalf.com> - 2016-07-21 16:00 +0200

csiph-web