Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1440924 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-07-11 23:50 +0200 |
| Last post | 2016-07-12 11:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Arnd Bergmann <arnd@arndb.de> - 2016-07-11 23:50 +0200
Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-12 09:20 +0200
Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Jiri Kosina <jikos@kernel.org> - 2016-07-12 11:20 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-07-11 23:50 +0200 |
| Subject | [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY |
| Message-ID | <rTRfs-4dj-13@gated-at.bofh.it> |
A recent commit added barry support to this driver, but that causes
a link failure when CONFIG_POWER_SUPPLY is not set:
drivers/hid/built-in.o: In function `hidpp_battery_get_property':
:(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
drivers/hid/built-in.o: In function `hidpp_raw_event':
:(.text+0x1b10c): undefined reference to `power_supply_changed'
drivers/hid/built-in.o: In function `hidpp_connect_event':
:(.text+0x1bd88): undefined reference to `devm_power_supply_register'
:(.text+0x1be30): undefined reference to `power_supply_powers'
This adds a dependency, identically to the other HID drivers that need this.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")
---
drivers/hid/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 78ac4811bd3c..4c6b59c9fa15 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -440,6 +440,7 @@ config HID_LOGITECH_DJ
config HID_LOGITECH_HIDPP
tristate "Logitech HID++ devices support"
depends on HID_LOGITECH
+ select POWER_SUPPLY
---help---
Support for Logitech devices relyingon the HID++ Logitech specification
--
2.9.0
[toc] | [next] | [standalone]
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2016-07-12 09:20 +0200 |
| Message-ID | <rU093-1KR-7@gated-at.bofh.it> |
| In reply to | #1440924 |
On Jul 11 2016 or thereabouts, Arnd Bergmann wrote:
> A recent commit added barry support to this driver, but that causes
> a link failure when CONFIG_POWER_SUPPLY is not set:
>
> drivers/hid/built-in.o: In function `hidpp_battery_get_property':
> :(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
> drivers/hid/built-in.o: In function `hidpp_raw_event':
> :(.text+0x1b10c): undefined reference to `power_supply_changed'
> drivers/hid/built-in.o: In function `hidpp_connect_event':
> :(.text+0x1bd88): undefined reference to `devm_power_supply_register'
> :(.text+0x1be30): undefined reference to `power_supply_powers'
>
> This adds a dependency, identically to the other HID drivers that need this.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")
Thanks for the fix.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 78ac4811bd3c..4c6b59c9fa15 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -440,6 +440,7 @@ config HID_LOGITECH_DJ
> config HID_LOGITECH_HIDPP
> tristate "Logitech HID++ devices support"
> depends on HID_LOGITECH
> + select POWER_SUPPLY
> ---help---
> Support for Logitech devices relyingon the HID++ Logitech specification
>
> --
> 2.9.0
>
[toc] | [prev] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2016-07-12 11:20 +0200 |
| Message-ID | <rU21c-2W2-5@gated-at.bofh.it> |
| In reply to | #1441103 |
On Tue, 12 Jul 2016, Benjamin Tissoires wrote:
> > A recent commit added barry support to this driver, but that causes
> > a link failure when CONFIG_POWER_SUPPLY is not set:
> >
> > drivers/hid/built-in.o: In function `hidpp_battery_get_property':
> > :(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
> > drivers/hid/built-in.o: In function `hidpp_raw_event':
> > :(.text+0x1b10c): undefined reference to `power_supply_changed'
> > drivers/hid/built-in.o: In function `hidpp_connect_event':
> > :(.text+0x1bd88): undefined reference to `devm_power_supply_register'
> > :(.text+0x1be30): undefined reference to `power_supply_powers'
> >
> > This adds a dependency, identically to the other HID drivers that need this.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")
>
> Thanks for the fix.
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Thanks. I am pushing this to for-4.8/logitech-hidpp-battery, but I will be
unmerging that branch from 'for-next' shortly anyway, as the whole
patchset is currently on hold.
--
Jiri Kosina
SUSE Labs
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web