Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY
Date	2016-07-12 11:20 +0200
Message-ID	<rU21c-2W2-5@gated-at.bofh.it> (permalink)
References	<rTRfs-4dj-13@gated-at.bofh.it> <rU093-1KR-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 12 Jul 2016, Benjamin Tissoires wrote:

> > A recent commit added barry support to this driver, but that causes
> > a link failure when CONFIG_POWER_SUPPLY is not set:
> > 
> > drivers/hid/built-in.o: In function `hidpp_battery_get_property':
> > :(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
> > drivers/hid/built-in.o: In function `hidpp_raw_event':
> > :(.text+0x1b10c): undefined reference to `power_supply_changed'
> > drivers/hid/built-in.o: In function `hidpp_connect_event':
> > :(.text+0x1bd88): undefined reference to `devm_power_supply_register'
> > :(.text+0x1be30): undefined reference to `power_supply_powers'
> > 
> > This adds a dependency, identically to the other HID drivers that need this.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")
> 
> Thanks for the fix.
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Thanks. I am pushing this to for-4.8/logitech-hidpp-battery, but I will be 
unmerging that branch from 'for-next' shortly anyway, as the whole 
patchset is currently on hold.

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Arnd Bergmann <arnd@arndb.de> - 2016-07-11 23:50 +0200
  Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-12 09:20 +0200
    Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Jiri Kosina <jikos@kernel.org> - 2016-07-12 11:20 +0200

csiph-web