Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1440924

[PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY

Show all headers | View raw

A recent commit added barry support to this driver, but that causes
a link failure when CONFIG_POWER_SUPPLY is not set:

drivers/hid/built-in.o: In function `hidpp_battery_get_property':
:(.text+0x1a834): undefined reference to `power_supply_get_drvdata'
drivers/hid/built-in.o: In function `hidpp_raw_event':
:(.text+0x1b10c): undefined reference to `power_supply_changed'
drivers/hid/built-in.o: In function `hidpp_connect_event':
:(.text+0x1bd88): undefined reference to `devm_power_supply_register'
:(.text+0x1be30): undefined reference to `power_supply_powers'

This adds a dependency, identically to the other HID drivers that need this.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5a2b190cddb9 ("HID: logitech-hidpp: add battery support for HID++ 2.0 devices")
---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 78ac4811bd3c..4c6b59c9fa15 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -440,6 +440,7 @@ config HID_LOGITECH_DJ
 config HID_LOGITECH_HIDPP
 	tristate "Logitech HID++ devices support"
 	depends on HID_LOGITECH
+	select POWER_SUPPLY
 	---help---
 	Support for Logitech devices relyingon the HID++ Logitech specification
 
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Arnd Bergmann <arnd@arndb.de> - 2016-07-11 23:50 +0200
  Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-12 09:20 +0200
    Re: [PATCH] HID: logitech-hidpp: select CONFIG_POWER_SUPPLY Jiri Kosina <jikos@kernel.org> - 2016-07-12 11:20 +0200

csiph-web