Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431932 > unrolled thread

[PATCH] ARM: s3c64xx: avoid warning about 'struct device_node'

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Arnd Bergmann <arnd@arndb.de> - 2016-06-27 13:10 +0200
    Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-27 13:40 +0200
      Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Arnd Bergmann <arnd@arndb.de> - 2016-07-11 13:20 +0200
        Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Arnd Bergmann <arnd@arndb.de> - 2016-07-11 13:40 +0200
          Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Arnd Bergmann <arnd@arndb.de> - 2016-07-14 14:50 +0200

#1431932 — [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node'

The change to simplify of_platform_populate() had an unintended
side-effect of introducing a build warning on s3c64xx:

In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]

This adds a forward-declaration for the structure name in the
header to avoid the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
---
Rob, can you apply this on top of the devicetree git so we don't
have to coordinate the merges?
---
 arch/arm/mach-s3c64xx/common.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-s3c64xx/common.h b/arch/arm/mach-s3c64xx/common.h
index 9eb864412911..4f204668f00e 100644
--- a/arch/arm/mach-s3c64xx/common.h
+++ b/arch/arm/mach-s3c64xx/common.h
@@ -24,6 +24,7 @@ void s3c64xx_init_io(struct map_desc *mach_desc, int size);
 
 void s3c64xx_restart(enum reboot_mode mode, const char *cmd);
 
+struct device_node;
 void s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f,
 	unsigned long xusbxti_f, bool is_s3c6400, void __iomem *reg_base);
 void s3c64xx_set_xtal_freq(unsigned long freq);
-- 
2.9.0

[toc] | [next] | [standalone]

#1431959

On 06/27/2016 01:02 PM, Arnd Bergmann wrote:
> The change to simplify of_platform_populate() had an unintended
> side-effect of introducing a build warning on s3c64xx:
> 
> In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
> arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> This adds a forward-declaration for the structure name in the
> header to avoid the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
> ---
> Rob, can you apply this on top of the devicetree git so we don't
> have to coordinate the merges?

Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

BR,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1440495

On Monday, June 27, 2016 1:33:51 PM CEST Krzysztof Kozlowski wrote:
> On 06/27/2016 01:02 PM, Arnd Bergmann wrote:
> > The change to simplify of_platform_populate() had an unintended
> > side-effect of introducing a build warning on s3c64xx:
> > 
> > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
> > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> > 
> > This adds a forward-declaration for the structure name in the
> > header to avoid the warning.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
> > ---
> > Rob, can you apply this on top of the devicetree git so we don't
> > have to coordinate the merges?
> 
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Hi Rob,

I still get the warning in every linux-next build, do you plan to pick
up the fix for the commit you merged, or should I try to work around it
in arm-soc and leave this as a bisection problem?

	Arnd

[toc] | [prev] | [next] | [standalone]

#1440501

On Monday, July 11, 2016 1:15:11 PM CEST Arnd Bergmann wrote:
> On Monday, June 27, 2016 1:33:51 PM CEST Krzysztof Kozlowski wrote:
> > On 06/27/2016 01:02 PM, Arnd Bergmann wrote:
> > > The change to simplify of_platform_populate() had an unintended
> > > side-effect of introducing a build warning on s3c64xx:
> > > 
> > > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
> > > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> > > 
> > > This adds a forward-declaration for the structure name in the
> > > header to avoid the warning.
> > > 
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
> > > ---
> > > Rob, can you apply this on top of the devicetree git so we don't
> > > have to coordinate the merges?
> > 
> > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Hi Rob,
> 
> I still get the warning in every linux-next build, do you plan to pick
> up the fix for the commit you merged, or should I try to work around it
> in arm-soc and leave this as a bisection problem?
> 

Now with Rob back on Cc.

	Arnd

[toc] | [prev] | [next] | [standalone]

#1443429

On Monday, July 11, 2016 1:40:45 PM CEST Arnd Bergmann wrote:
> On Monday, July 11, 2016 1:15:11 PM CEST Arnd Bergmann wrote:
> > On Monday, June 27, 2016 1:33:51 PM CEST Krzysztof Kozlowski wrote:
> > > On 06/27/2016 01:02 PM, Arnd Bergmann wrote:
> > > > The change to simplify of_platform_populate() had an unintended
> > > > side-effect of introducing a build warning on s3c64xx:
> > > > 
> > > > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
> > > > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> > > > 
> > > > This adds a forward-declaration for the structure name in the
> > > > header to avoid the warning.
> > > > 
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
> > > > ---
> > > > Rob, can you apply this on top of the devicetree git so we don't
> > > > have to coordinate the merges?
> > > 
> > > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > 
> > Hi Rob,
> > 
> > I still get the warning in every linux-next build, do you plan to pick
> > up the fix for the commit you merged, or should I try to work around it
> > in arm-soc and leave this as a bisection problem?
> > 
> 
> Now with Rob back on Cc.

I've applied it to arm-soc/next/cleanup now, so we can avoid the warning
in linux-next and in 4.8, though it is still present in the devicetree
git.

	Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web