Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node'

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node'
Date	2016-07-14 14:50 +0200
Message-ID	<rUOfx-1kh-41@gated-at.bofh.it> (permalink)
References	<rOCAq-7Tb-27@gated-at.bofh.it> <rTHpM-6ib-5@gated-at.bofh.it> <rTHJ8-6qA-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday, July 11, 2016 1:40:45 PM CEST Arnd Bergmann wrote:
> On Monday, July 11, 2016 1:15:11 PM CEST Arnd Bergmann wrote:
> > On Monday, June 27, 2016 1:33:51 PM CEST Krzysztof Kozlowski wrote:
> > > On 06/27/2016 01:02 PM, Arnd Bergmann wrote:
> > > > The change to simplify of_platform_populate() had an unintended
> > > > side-effect of introducing a build warning on s3c64xx:
> > > > 
> > > > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
> > > > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> > > > 
> > > > This adds a forward-declaration for the structure name in the
> > > > header to avoid the warning.
> > > > 
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
> > > > ---
> > > > Rob, can you apply this on top of the devicetree git so we don't
> > > > have to coordinate the merges?
> > > 
> > > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > 
> > Hi Rob,
> > 
> > I still get the warning in every linux-next build, do you plan to pick
> > up the fix for the commit you merged, or should I try to work around it
> > in arm-soc and leave this as a bisection problem?
> > 
> 
> Now with Rob back on Cc.

I've applied it to arm-soc/next/cleanup now, so we can avoid the warning
in linux-next and in 4.8, though it is still present in the devicetree
git.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Arnd Bergmann <arnd@arndb.de> - 2016-07-11 13:20 +0200
  Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Arnd Bergmann <arnd@arndb.de> - 2016-07-11 13:40 +0200
    Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Arnd Bergmann <arnd@arndb.de> - 2016-07-14 14:50 +0200

csiph-web