Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1431959

Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node'

Show all headers | View raw

On 06/27/2016 01:02 PM, Arnd Bergmann wrote:
> The change to simplify of_platform_populate() had an unintended
> side-effect of introducing a build warning on s3c64xx:
> 
> In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
> arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> This adds a forward-declaration for the structure name in the
> header to avoid the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
> ---
> Rob, can you apply this on top of the devicetree git so we don't
> have to coordinate the merges?

Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

BR,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Arnd Bergmann <arnd@arndb.de> - 2016-06-27 13:10 +0200
  Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-27 13:40 +0200

csiph-web