Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437017 > unrolled thread

[PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH net-next 01/24] rxrpc: Fix processing of  authenticated/encrypted jumbo packets David Howells <dhowells@redhat.com> - 2016-07-05 15:30 +0200
    Re: [PATCH net-next 01/24] rxrpc: Fix processing of  authenticated/encrypted jumbo packets Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-07-05 20:00 +0200
      Re: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets David Howells <dhowells@redhat.com> - 2016-07-05 21:30 +0200

#1437017 — [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets

When a jumbo packet is being split up and processed, the crypto checksum
for each split-out packet is in the jumbo header and needs placing in the
reconstructed packet header.

When commit 0d12f8a4027d021c9cc942f09f38d28288020c5d moved to keeping the
stored copy of the packet header in host byte order, this reconstruction
was missed.

Found with sparse with CF=-D__CHECK_ENDIAN__:

    ../net/rxrpc/input.c:479:33: warning: incorrect type in assignment (different base types)
    ../net/rxrpc/input.c:479:33:    expected unsigned short [unsigned] [usertype] _rsvd
    ../net/rxrpc/input.c:479:33:    got restricted __be16 [addressable] [usertype] _rsvd

Signed-off-by: David Howells <dhowells@redhat.com>
---

 net/rxrpc/input.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c
index f4bd57b77b93..5f26cae43069 100644
--- a/net/rxrpc/input.c
+++ b/net/rxrpc/input.c
@@ -476,7 +476,7 @@ static void rxrpc_process_jumbo_packet(struct rxrpc_call *call,
 		sp->hdr.seq	+= 1;
 		sp->hdr.serial	+= 1;
 		sp->hdr.flags	= jhdr.flags;
-		sp->hdr._rsvd	= jhdr._rsvd;
+		sp->hdr._rsvd	= ntohs(jhdr._rsvd);
 
 		_proto("Rx DATA Jumbo %%%u", sp->hdr.serial - 1);
 

[toc] | [next] | [standalone]

#1437217

Hello.

On 07/05/2016 04:12 PM, David Howells wrote:

> When a jumbo packet is being split up and processed, the crypto checksum
> for each split-out packet is in the jumbo header and needs placing in the
> reconstructed packet header.
>
> When commit 0d12f8a4027d021c9cc942f09f38d28288020c5d moved to keeping the

    scripts/checkpatch.pl now enforces the common commit citing style as for 
the Fixes: tag and the patch description, you need to specify the summary too.

> stored copy of the packet header in host byte order, this reconstruction
> was missed.
>
> Found with sparse with CF=-D__CHECK_ENDIAN__:
>
>     ../net/rxrpc/input.c:479:33: warning: incorrect type in assignment (different base types)
>     ../net/rxrpc/input.c:479:33:    expected unsigned short [unsigned] [usertype] _rsvd
>     ../net/rxrpc/input.c:479:33:    got restricted __be16 [addressable] [usertype] _rsvd
>
> Signed-off-by: David Howells <dhowells@redhat.com>
[...]

MBR, Sergei

[toc] | [prev] | [next] | [standalone]

#1437240 — Re: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets

Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:

> > When commit 0d12f8a4027d021c9cc942f09f38d28288020c5d moved to keeping the
> 
>    scripts/checkpatch.pl now enforces the common commit citing style as for
> the Fixes: tag and the patch description, you need to specify the summary too.

I've now added a "Fixes:" line for the commit, but checkpatch erroneously
complains that I'm mentioning a commit ID in the commit text.

David

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web