Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1437217
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets |
| Date | 2016-07-05 20:00 +0200 |
| Message-ID | <rRCNz-5ZL-13@gated-at.bofh.it> (permalink) |
| References | <rRyqB-3hh-3@gated-at.bofh.it> <rRyAi-3kG-41@gated-at.bofh.it> |
| Organization | Cogent Embedded |
Hello.
On 07/05/2016 04:12 PM, David Howells wrote:
> When a jumbo packet is being split up and processed, the crypto checksum
> for each split-out packet is in the jumbo header and needs placing in the
> reconstructed packet header.
>
> When commit 0d12f8a4027d021c9cc942f09f38d28288020c5d moved to keeping the
scripts/checkpatch.pl now enforces the common commit citing style as for
the Fixes: tag and the patch description, you need to specify the summary too.
> stored copy of the packet header in host byte order, this reconstruction
> was missed.
>
> Found with sparse with CF=-D__CHECK_ENDIAN__:
>
> ../net/rxrpc/input.c:479:33: warning: incorrect type in assignment (different base types)
> ../net/rxrpc/input.c:479:33: expected unsigned short [unsigned] [usertype] _rsvd
> ../net/rxrpc/input.c:479:33: got restricted __be16 [addressable] [usertype] _rsvd
>
> Signed-off-by: David Howells <dhowells@redhat.com>
[...]
MBR, Sergei
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets David Howells <dhowells@redhat.com> - 2016-07-05 15:30 +0200
Re: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-07-05 20:00 +0200
Re: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets David Howells <dhowells@redhat.com> - 2016-07-05 21:30 +0200
csiph-web