[PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets
Date	2016-07-05 15:30 +0200
Message-ID	<rRyAi-3kG-41@gated-at.bofh.it> (permalink)
References	<rRyqB-3hh-3@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

When a jumbo packet is being split up and processed, the crypto checksum
for each split-out packet is in the jumbo header and needs placing in the
reconstructed packet header.

When commit 0d12f8a4027d021c9cc942f09f38d28288020c5d moved to keeping the
stored copy of the packet header in host byte order, this reconstruction
was missed.

Found with sparse with CF=-D__CHECK_ENDIAN__:

    ../net/rxrpc/input.c:479:33: warning: incorrect type in assignment (different base types)
    ../net/rxrpc/input.c:479:33:    expected unsigned short [unsigned] [usertype] _rsvd
    ../net/rxrpc/input.c:479:33:    got restricted __be16 [addressable] [usertype] _rsvd

Signed-off-by: David Howells <dhowells@redhat.com>
---

 net/rxrpc/input.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rxrpc/input.c b/net/rxrpc/input.c
index f4bd57b77b93..5f26cae43069 100644
--- a/net/rxrpc/input.c
+++ b/net/rxrpc/input.c
@@ -476,7 +476,7 @@ static void rxrpc_process_jumbo_packet(struct rxrpc_call *call,
 		sp->hdr.seq	+= 1;
 		sp->hdr.serial	+= 1;
 		sp->hdr.flags	= jhdr.flags;
-		sp->hdr._rsvd	= jhdr._rsvd;
+		sp->hdr._rsvd	= ntohs(jhdr._rsvd);
 
 		_proto("Rx DATA Jumbo %%%u", sp->hdr.serial - 1);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 01/24] rxrpc: Fix processing of  authenticated/encrypted jumbo packets David Howells <dhowells@redhat.com> - 2016-07-05 15:30 +0200
  Re: [PATCH net-next 01/24] rxrpc: Fix processing of  authenticated/encrypted jumbo packets Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-07-05 20:00 +0200
    Re: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets David Howells <dhowells@redhat.com> - 2016-07-05 21:30 +0200

csiph-web