Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1433799 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-06-29 16:40 +0200 |
| Last post | 2016-06-29 23:30 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] power: qcom-smbb: add extcon dependency Arnd Bergmann <arnd@arndb.de> - 2016-06-29 16:40 +0200
Re: [PATCH] power: qcom-smbb: add extcon dependency Sebastian Reichel <sre@kernel.org> - 2016-06-29 16:40 +0200
Re: [PATCH] power: qcom-smbb: add extcon dependency Stephen Boyd <sboyd@codeaurora.org> - 2016-06-29 20:20 +0200
Re: [PATCH] power: qcom-smbb: add extcon dependency Sebastian Reichel <sre@kernel.org> - 2016-06-29 23:20 +0200
Re: [PATCH] power: qcom-smbb: add extcon dependency Arnd Bergmann <arnd@arndb.de> - 2016-06-29 23:30 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-06-29 16:40 +0200 |
| Subject | [PATCH] power: qcom-smbb: add extcon dependency |
| Message-ID | <rPoOK-5l8-33@gated-at.bofh.it> |
Building the smbb driver without extcon results in a link failure:
drivers/power/built-in.o: In function `smbb_usb_valid_handler':
:(.text+0x3190): undefined reference to `extcon_set_cable_state_'
drivers/power/built-in.o: In function `smbb_charger_probe':
:(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
:(.text+0x3898): undefined reference to `devm_extcon_dev_register'
This adds a Kconfig dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
---
drivers/power/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 0f11a0f4c369..acd4a1524a1e 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -394,6 +394,7 @@ config CHARGER_QCOM_SMBB
tristate "Qualcomm Switch-Mode Battery Charger and Boost"
depends on MFD_SPMI_PMIC || COMPILE_TEST
depends on OF
+ depends on EXTCON
help
Say Y to include support for the Switch-Mode Battery Charger and
Boost (SMBB) hardware found in Qualcomm PM8941 PMICs. The charger
--
2.9.0
[toc] | [next] | [standalone]
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2016-06-29 16:40 +0200 |
| Message-ID | <rPoOK-5l8-37@gated-at.bofh.it> |
| In reply to | #1433799 |
[Multipart message — attachments visible in raw view] — view raw
Hi,
On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
> Building the smbb driver without extcon results in a link failure:
>
> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
> drivers/power/built-in.o: In function `smbb_charger_probe':
> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
>
> This adds a Kconfig dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
> ---
> drivers/power/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 0f11a0f4c369..acd4a1524a1e 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -394,6 +394,7 @@ config CHARGER_QCOM_SMBB
> tristate "Qualcomm Switch-Mode Battery Charger and Boost"
> depends on MFD_SPMI_PMIC || COMPILE_TEST
> depends on OF
> + depends on EXTCON
> help
> Say Y to include support for the Switch-Mode Battery Charger and
> Boost (SMBB) hardware found in Qualcomm PM8941 PMICs. The charger
Thanks, queued.
-- Sebastian
[toc] | [prev] | [next] | [standalone]
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2016-06-29 20:20 +0200 |
| Message-ID | <rPsfE-7yY-21@gated-at.bofh.it> |
| In reply to | #1433805 |
On 06/29/2016 07:38 AM, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
>> Building the smbb driver without extcon results in a link failure:
>>
>> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
>> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
>> drivers/power/built-in.o: In function `smbb_charger_probe':
>> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
>> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
>>
>> This adds a Kconfig dependency.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
extcon use was only recently introduced so this should be
Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable
detection")
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2016-06-29 23:20 +0200 |
| Message-ID | <rPv3Q-Q1-19@gated-at.bofh.it> |
| In reply to | #1433953 |
[Multipart message — attachments visible in raw view] — view raw
Hi,
On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote:
> On 06/29/2016 07:38 AM, Sebastian Reichel wrote:
> > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
> >> Building the smbb driver without extcon results in a link failure:
> >>
> >> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
> >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
> >> drivers/power/built-in.o: In function `smbb_charger_probe':
> >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
> >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
> >>
> >> This adds a Kconfig dependency.
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
>
> extcon use was only recently introduced so this should be
>
> Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable
> detection")
Right, I didn't notice the Fixes line is wrong. Since I will have to
rebase now, I will just squash this into 0b7fe26ae602.
-- Sebastian
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-06-29 23:30 +0200 |
| Message-ID | <rPvdw-Tj-11@gated-at.bofh.it> |
| In reply to | #1434060 |
On Wednesday, June 29, 2016 11:09:58 PM CEST Sebastian Reichel wrote:
> On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote:
> > On 06/29/2016 07:38 AM, Sebastian Reichel wrote:
> > > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
> > >> Building the smbb driver without extcon results in a link failure:
> > >>
> > >> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
> > >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
> > >> drivers/power/built-in.o: In function `smbb_charger_probe':
> > >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
> > >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
> > >>
> > >> This adds a Kconfig dependency.
> > >>
> > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
> >
> > extcon use was only recently introduced so this should be
> >
> > Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable
> > detection")
>
> Right, I didn't notice the Fixes line is wrong. Since I will have to
> rebase now, I will just squash this into 0b7fe26ae602.
Ok, thanks and sorry for the mixup, I must have pasted the wrong line.
Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web