Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1433805

Re: [PATCH] power: qcom-smbb: add extcon dependency

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
> Building the smbb driver without extcon results in a link failure:
> 
> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
> drivers/power/built-in.o: In function `smbb_charger_probe':
> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
> 
> This adds a Kconfig dependency.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
> ---
>  drivers/power/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 0f11a0f4c369..acd4a1524a1e 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -394,6 +394,7 @@ config CHARGER_QCOM_SMBB
>  	tristate "Qualcomm Switch-Mode Battery Charger and Boost"
>  	depends on MFD_SPMI_PMIC || COMPILE_TEST
>  	depends on OF
> +	depends on EXTCON
>  	help
>  	  Say Y to include support for the Switch-Mode Battery Charger and
>  	  Boost (SMBB) hardware found in Qualcomm PM8941 PMICs.  The charger

Thanks, queued.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] power: qcom-smbb: add extcon dependency Arnd Bergmann <arnd@arndb.de> - 2016-06-29 16:40 +0200
  Re: [PATCH] power: qcom-smbb: add extcon dependency Sebastian Reichel <sre@kernel.org> - 2016-06-29 16:40 +0200
    Re: [PATCH] power: qcom-smbb: add extcon dependency Stephen Boyd <sboyd@codeaurora.org> - 2016-06-29 20:20 +0200
      Re: [PATCH] power: qcom-smbb: add extcon dependency Sebastian Reichel <sre@kernel.org> - 2016-06-29 23:20 +0200
        Re: [PATCH] power: qcom-smbb: add extcon dependency Arnd Bergmann <arnd@arndb.de> - 2016-06-29 23:30 +0200

csiph-web