Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1434060

Re: [PATCH] power: qcom-smbb: add extcon dependency

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote:
> On 06/29/2016 07:38 AM, Sebastian Reichel wrote:
> > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
> >> Building the smbb driver without extcon results in a link failure:
> >>
> >> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
> >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
> >> drivers/power/built-in.o: In function `smbb_charger_probe':
> >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
> >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
> >>
> >> This adds a Kconfig dependency.
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
> 
> extcon use was only recently introduced so this should be
> 
> Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable
> detection")

Right, I didn't notice the Fixes line is wrong. Since I will have to
rebase now, I will just squash this into 0b7fe26ae602.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] power: qcom-smbb: add extcon dependency Arnd Bergmann <arnd@arndb.de> - 2016-06-29 16:40 +0200
  Re: [PATCH] power: qcom-smbb: add extcon dependency Sebastian Reichel <sre@kernel.org> - 2016-06-29 16:40 +0200
    Re: [PATCH] power: qcom-smbb: add extcon dependency Stephen Boyd <sboyd@codeaurora.org> - 2016-06-29 20:20 +0200
      Re: [PATCH] power: qcom-smbb: add extcon dependency Sebastian Reichel <sre@kernel.org> - 2016-06-29 23:20 +0200
        Re: [PATCH] power: qcom-smbb: add extcon dependency Arnd Bergmann <arnd@arndb.de> - 2016-06-29 23:30 +0200

csiph-web