Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1430661 > unrolled thread
| Started by | Raashid Muhammed <raashidmuhammed@zilogic.com> |
|---|---|
| First post | 2016-06-24 15:40 +0200 |
| Last post | 2016-06-24 16:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. Raashid Muhammed <raashidmuhammed@zilogic.com> - 2016-06-24 15:40 +0200
Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-24 15:50 +0200
Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. raashidmuhammed <raashidmuhammed@zilogic.com> - 2016-06-24 16:00 +0200
Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. Raashid Muhammed <raashidmuhammed@zilogic.com> - 2016-06-24 16:40 +0200
| From | Raashid Muhammed <raashidmuhammed@zilogic.com> |
|---|---|
| Date | 2016-06-24 15:40 +0200 |
| Subject | [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. |
| Message-ID | <rNzuV-cP-1@gated-at.bofh.it> |
Add power led node and rename status led node.
Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
---
arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
index be409f2..814753a 100644
--- a/arch/arm/boot/dts/at91-sam9_l9260.dts
+++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
@@ -106,11 +106,16 @@
leds {
compatible = "gpio-leds";
- b0 {
- label = "b0";
- gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "heartbeat";
+ pwr_led {
+ label = "sam9-l9260:yellow:pwr";
+ gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "cpu0";
};
+ status_led {
+ label = "sam9-l9260:green:status";
+ gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "timer";
+ };
};
};
--
2.1.4
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2016-06-24 15:50 +0200 |
| Message-ID | <rNzEC-h8-9@gated-at.bofh.it> |
| In reply to | #1430661 |
Hi,
On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
> Add power led node and rename status led node.
>
Well, I'm ok with the change but this does more:
> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
> ---
> arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
> index be409f2..814753a 100644
> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
> @@ -106,11 +106,16 @@
> leds {
> compatible = "gpio-leds";
>
> - b0 {
> - label = "b0";
> - gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
> - linux,default-trigger = "heartbeat";
> + pwr_led {
> + label = "sam9-l9260:yellow:pwr";
> + gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "cpu0";
> };
>
> + status_led {
> + label = "sam9-l9260:green:status";
> + gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "timer";
This trigger is also switched from heartbeat to timer, is this
intentional?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | raashidmuhammed <raashidmuhammed@zilogic.com> |
|---|---|
| Date | 2016-06-24 16:00 +0200 |
| Message-ID | <rNzOh-ly-1@gated-at.bofh.it> |
| In reply to | #1430677 |
On 06/24/2016 07:10 PM, Alexandre Belloni wrote:
> Hi,
>
> On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
>> Add power led node and rename status led node.
>>
> Well, I'm ok with the change but this does more:
>
>> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
>> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
>> ---
>> arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>> 1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> index be409f2..814753a 100644
>> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
>> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> @@ -106,11 +106,16 @@
>> leds {
>> compatible = "gpio-leds";
>>
>> - b0 {
>> - label = "b0";
>> - gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
>> - linux,default-trigger = "heartbeat";
>> + pwr_led {
>> + label = "sam9-l9260:yellow:pwr";
>> + gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "cpu0";
>> };
>>
>> + status_led {
>> + label = "sam9-l9260:green:status";
>> + gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
>> + linux,default-trigger = "timer";
> This trigger is also switched from heartbeat to timer, is this
> intentional?
>
Yes, that is intentional. I should have included that in the commit message.
[toc] | [prev] | [next] | [standalone]
| From | Raashid Muhammed <raashidmuhammed@zilogic.com> |
|---|---|
| Date | 2016-06-24 16:40 +0200 |
| Message-ID | <rNAr0-NX-11@gated-at.bofh.it> |
| In reply to | #1430677 |
Alexandre Belloni writes:
> Hi,
>
> On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
>> Add power led node and rename status led node.
>>
>
> Well, I'm ok with the change but this does more:
>
>> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
>> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
>> ---
>> arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>> 1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> index be409f2..814753a 100644
>> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
>> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> @@ -106,11 +106,16 @@
>> leds {
>> compatible = "gpio-leds";
>>
>> - b0 {
>> - label = "b0";
>> - gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
>> - linux,default-trigger = "heartbeat";
>> + pwr_led {
>> + label = "sam9-l9260:yellow:pwr";
>> + gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "cpu0";
>> };
>>
>> + status_led {
>> + label = "sam9-l9260:green:status";
>> + gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
>> + linux,default-trigger = "timer";
>
> This trigger is also switched from heartbeat to timer, is this
> intentional?
Yes, that is intentional. I should have included that in the commit
message.
--
Sent with my mu4e
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web