Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.

From	Raashid Muhammed <raashidmuhammed@zilogic.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
Date	2016-06-24 16:40 +0200
Message-ID	<rNAr0-NX-11@gated-at.bofh.it> (permalink)
References	<rNzuV-cP-3@gated-at.bofh.it> <rNzuV-cP-1@gated-at.bofh.it> <rNzEC-h8-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Alexandre Belloni writes:

> Hi,
>
> On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
>> Add power led node and rename status led node.
>>
>
> Well, I'm ok with the change but this does more:
>
>> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
>> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
>> ---
>>  arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>>  1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> index be409f2..814753a 100644
>> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
>> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> @@ -106,11 +106,16 @@
>>  	leds {
>>  		compatible = "gpio-leds";
>>
>> -		b0 {
>> -			label = "b0";
>> -			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
>> -			linux,default-trigger = "heartbeat";
>> +		pwr_led {
>> +			label = "sam9-l9260:yellow:pwr";
>> +			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "cpu0";
>>  		};
>>
>> +		status_led {
>> +			label = "sam9-l9260:green:status";
>> +			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger = "timer";
>
> This trigger is also switched from heartbeat to timer, is this
> intentional?

Yes, that is intentional. I should have included that in the commit
message.

--
Sent with my mu4e

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. Raashid Muhammed <raashidmuhammed@zilogic.com> - 2016-06-24 15:40 +0200
  Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-24 15:50 +0200
    Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. raashidmuhammed <raashidmuhammed@zilogic.com> - 2016-06-24 16:00 +0200
    Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. Raashid Muhammed <raashidmuhammed@zilogic.com> - 2016-06-24 16:40 +0200

csiph-web