Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1348578 > unrolled thread

[PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0 Wolfram Sang <wsa@the-dreams.de> - 2016-03-02 23:40 +0100
    Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid  division by 0 Guenter Roeck <linux@roeck-us.net> - 2016-03-03 05:30 +0100
      Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid  division by 0 Wolfram Sang <wsa@the-dreams.de> - 2016-03-03 09:20 +0100

#1348578 — [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0

From: Wolfram Sang <wsa+renesas@sang-engineering.com>

The clk API may return 0 on clk_get_rate, so we should check the result before
using it as a divisor.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Should go individually via subsystem tree.

 drivers/watchdog/tangox_wdt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/watchdog/tangox_wdt.c b/drivers/watchdog/tangox_wdt.c
index 709c1ed6fd79b9..cc702718ae4dbb 100644
--- a/drivers/watchdog/tangox_wdt.c
+++ b/drivers/watchdog/tangox_wdt.c
@@ -139,6 +139,8 @@ static int tangox_wdt_probe(struct platform_device *pdev)
 		return err;
 
 	dev->clk_rate = clk_get_rate(dev->clk);
+	if (!dev->clk_rate)
+		return -EINVAL;
 
 	dev->wdt.parent = &pdev->dev;
 	dev->wdt.info = &tangox_wdt_info;
-- 
2.7.0

[toc] | [next] | [standalone]

#1348774 — Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0

On Wed, Mar 02, 2016 at 11:33:37PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> The clk API may return 0 on clk_get_rate, so we should check the result before
> using it as a divisor.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> Should go individually via subsystem tree.
> 
>  drivers/watchdog/tangox_wdt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/watchdog/tangox_wdt.c b/drivers/watchdog/tangox_wdt.c
> index 709c1ed6fd79b9..cc702718ae4dbb 100644
> --- a/drivers/watchdog/tangox_wdt.c
> +++ b/drivers/watchdog/tangox_wdt.c
> @@ -139,6 +139,8 @@ static int tangox_wdt_probe(struct platform_device *pdev)
>  		return err;
>  
>  	dev->clk_rate = clk_get_rate(dev->clk);
> +	if (!dev->clk_rate)
> +		return -EINVAL;

May be a nitpick, but clk_disable_unprepare() is missing.

Guenter

>  
>  	dev->wdt.parent = &pdev->dev;
>  	dev->wdt.info = &tangox_wdt_info;
> -- 
> 2.7.0
> 

[toc] | [prev] | [next] | [standalone]

#1348878 — Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0

[Multipart message — attachments visible in raw view] — view raw

> > +	if (!dev->clk_rate)
> > +		return -EINVAL;
> 
> May be a nitpick, but clk_disable_unprepare() is missing.

Oh, definately not a nitpick in my book, will resend! Thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web