Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0
Date	2016-03-03 09:20 +0100
Message-ID	<r8wEi-4cL-21@gated-at.bofh.it> (permalink)
References	<r8nAZ-682-5@gated-at.bofh.it> <r8nB0-682-15@gated-at.bofh.it> <r8t3J-1BU-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> > +	if (!dev->clk_rate)
> > +		return -EINVAL;
> 
> May be a nitpick, but clk_disable_unprepare() is missing.

Oh, definately not a nitpick in my book, will resend! Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0 Wolfram Sang <wsa@the-dreams.de> - 2016-03-02 23:40 +0100
  Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid  division by 0 Guenter Roeck <linux@roeck-us.net> - 2016-03-03 05:30 +0100
    Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid  division by 0 Wolfram Sang <wsa@the-dreams.de> - 2016-03-03 09:20 +0100

csiph-web