[PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	[PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0
Date	2016-03-02 23:40 +0100
Message-ID	<r8nB0-682-15@gated-at.bofh.it> (permalink)
References	<r8nAZ-682-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Wolfram Sang <wsa+renesas@sang-engineering.com>

The clk API may return 0 on clk_get_rate, so we should check the result before
using it as a divisor.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Should go individually via subsystem tree.

 drivers/watchdog/tangox_wdt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/watchdog/tangox_wdt.c b/drivers/watchdog/tangox_wdt.c
index 709c1ed6fd79b9..cc702718ae4dbb 100644
--- a/drivers/watchdog/tangox_wdt.c
+++ b/drivers/watchdog/tangox_wdt.c
@@ -139,6 +139,8 @@ static int tangox_wdt_probe(struct platform_device *pdev)
 		return err;
 
 	dev->clk_rate = clk_get_rate(dev->clk);
+	if (!dev->clk_rate)
+		return -EINVAL;
 
 	dev->wdt.parent = &pdev->dev;
 	dev->wdt.info = &tangox_wdt_info;
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid division by 0 Wolfram Sang <wsa@the-dreams.de> - 2016-03-02 23:40 +0100
  Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid  division by 0 Guenter Roeck <linux@roeck-us.net> - 2016-03-03 05:30 +0100
    Re: [PATCH 6/6] watchdog: tangox_wdt: test clock rate to avoid  division by 0 Wolfram Sang <wsa@the-dreams.de> - 2016-03-03 09:20 +0100

csiph-web