Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1349738 > unrolled thread

[PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

Started byKrzysztof Kozlowski <k.kozlowski@samsung.com>
First post2016-03-04 02:10 +0100
Last post2016-03-05 05:30 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-04 02:10 +0100
    Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-04 08:10 +0100
    Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Holger Schurig <holgerschurig@gmail.com> - 2016-03-04 08:10 +0100
    Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on  HAS_IOMEM Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-03-04 12:10 +0100
      Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-05 05:30 +0100

#1349738 — [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-03-04 02:10 +0100
Subject[PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM
Message-ID<r8MpH-7h0-1@gated-at.bofh.it>
The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
direct dependencies.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---

Changes since v1:
1. Fix comments from Arnd: VIDEO_OMAP3 does not require it, however
   VIDEO_S5P_FIMC still needs it.
---
 drivers/media/platform/exynos4-is/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/platform/exynos4-is/Kconfig
index 57d42c6172c5..c4317b99d257 100644
--- a/drivers/media/platform/exynos4-is/Kconfig
+++ b/drivers/media/platform/exynos4-is/Kconfig
@@ -17,6 +17,7 @@ config VIDEO_S5P_FIMC
 	tristate "S5P/EXYNOS4 FIMC/CAMIF camera interface driver"
 	depends on I2C
 	depends on HAS_DMA
+	depends on HAS_IOMEM	# For MFD_SYSCON
 	select VIDEOBUF2_DMA_CONTIG
 	select V4L2_MEM2MEM_DEV
 	select MFD_SYSCON
-- 
2.5.0

[toc] | [next] | [standalone]

#1349901

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-03-04 08:10 +0100
Message-ID<r8S25-2Yy-1@gated-at.bofh.it>
In reply to#1349738
On 04.03.2016 16:03, Holger Schurig wrote:
> Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
> 
>> +	depends on HAS_IOMEM	# For MFD_SYSCON
>                             ^^^^^^^^^^^^^^^^
> 
> I think this comment is not necessary, it's also highly unusual. On
> other words: other patches like this don't add such comments.
> 
> You can always use "git blame" to find out why some line has changed the
> way it changed ...

No problem, I can remove it. I thought it might be useful since this
dependency is not for the driver but for selected item.

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1349902 — Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

FromHolger Schurig <holgerschurig@gmail.com>
Date2016-03-04 08:10 +0100
SubjectRe: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM
Message-ID<r8S25-2Yy-3@gated-at.bofh.it>
In reply to#1349738
Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:

> +	depends on HAS_IOMEM	# For MFD_SYSCON
                            ^^^^^^^^^^^^^^^^

I think this comment is not necessary, it's also highly unusual. On
other words: other patches like this don't add such comments.

You can always use "git blame" to find out why some line has changed the
way it changed ...

[toc] | [prev] | [next] | [standalone]

#1350157

FromSylwester Nawrocki <s.nawrocki@samsung.com>
Date2016-03-04 12:10 +0100
Message-ID<r8VMl-5IQ-7@gated-at.bofh.it>
In reply to#1349738
On 03/04/2016 02:02 AM, Krzysztof Kozlowski wrote:
> The MFD_SYSCON depends on HAS_IOMEM so when selecting 
> it avoid unmet direct dependencies.

> diff --git a/drivers/media/platform/exynos4-is/Kconfig 
> b/drivers/media/platform/exynos4-is/Kconfig
> index 57d42c6172c5..c4317b99d257 100644
> --- a/drivers/media/platform/exynos4-is/Kconfig
> +++ b/drivers/media/platform/exynos4-is/Kconfig
> @@ -17,6 +17,7 @@ config VIDEO_S5P_FIMC
>  	tristate "S5P/EXYNOS4 FIMC/CAMIF camera interface driver"
>  	depends on I2C
>  	depends on HAS_DMA
> +	depends on HAS_IOMEM	# For MFD_SYSCON
>  	select VIDEOBUF2_DMA_CONTIG
>  	select V4L2_MEM2MEM_DEV
>  	select MFD_SYSCON

While we are already at it, shouldn't "depends on HAS_IOMEM"
be instead added at the top level entry in this Kconfig file,
i.e. "config VIDEO_SAMSUNG_EXYNOS4_IS" ? For things like
devm_ioremap_resource() depending on HAS_IOMEM and used in all
the sub-drivers, enabled by VIDEO_SAMSUNG_EXYNOS4_IS?

-- 
Thanks,
Sylwester

[toc] | [prev] | [next] | [standalone]

#1350785 — Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-03-05 05:30 +0100
SubjectRe: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM
Message-ID<r9c0Q-H5-77@gated-at.bofh.it>
In reply to#1350157
2016-03-04 20:02 GMT+09:00 Sylwester Nawrocki <s.nawrocki@samsung.com>:
> On 03/04/2016 02:02 AM, Krzysztof Kozlowski wrote:
>> The MFD_SYSCON depends on HAS_IOMEM so when selecting
>> it avoid unmet direct dependencies.
>
>> diff --git a/drivers/media/platform/exynos4-is/Kconfig
>> b/drivers/media/platform/exynos4-is/Kconfig
>> index 57d42c6172c5..c4317b99d257 100644
>> --- a/drivers/media/platform/exynos4-is/Kconfig
>> +++ b/drivers/media/platform/exynos4-is/Kconfig
>> @@ -17,6 +17,7 @@ config VIDEO_S5P_FIMC
>>       tristate "S5P/EXYNOS4 FIMC/CAMIF camera interface driver"
>>       depends on I2C
>>       depends on HAS_DMA
>> +     depends on HAS_IOMEM    # For MFD_SYSCON
>>       select VIDEOBUF2_DMA_CONTIG
>>       select V4L2_MEM2MEM_DEV
>>       select MFD_SYSCON
>
> While we are already at it, shouldn't "depends on HAS_IOMEM"
> be instead added at the top level entry in this Kconfig file,
> i.e. "config VIDEO_SAMSUNG_EXYNOS4_IS" ? For things like
> devm_ioremap_resource() depending on HAS_IOMEM and used in all
> the sub-drivers, enabled by VIDEO_SAMSUNG_EXYNOS4_IS?

Indeed that would make sense... but now after some more looking at it,
even this patch is not needed. All these drivers are children of
MEDIA_SUPPORT which already depends on HAS_IOMEM.

Best regards,
Krzysztof

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web