Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1350157
| From | Sylwester Nawrocki <s.nawrocki@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM |
| Date | 2016-03-04 12:10 +0100 |
| Message-ID | <r8VMl-5IQ-7@gated-at.bofh.it> (permalink) |
| References | <r8MpH-7h0-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/04/2016 02:02 AM, Krzysztof Kozlowski wrote: > The MFD_SYSCON depends on HAS_IOMEM so when selecting > it avoid unmet direct dependencies. > diff --git a/drivers/media/platform/exynos4-is/Kconfig > b/drivers/media/platform/exynos4-is/Kconfig > index 57d42c6172c5..c4317b99d257 100644 > --- a/drivers/media/platform/exynos4-is/Kconfig > +++ b/drivers/media/platform/exynos4-is/Kconfig > @@ -17,6 +17,7 @@ config VIDEO_S5P_FIMC > tristate "S5P/EXYNOS4 FIMC/CAMIF camera interface driver" > depends on I2C > depends on HAS_DMA > + depends on HAS_IOMEM # For MFD_SYSCON > select VIDEOBUF2_DMA_CONTIG > select V4L2_MEM2MEM_DEV > select MFD_SYSCON While we are already at it, shouldn't "depends on HAS_IOMEM" be instead added at the top level entry in this Kconfig file, i.e. "config VIDEO_SAMSUNG_EXYNOS4_IS" ? For things like devm_ioremap_resource() depending on HAS_IOMEM and used in all the sub-drivers, enabled by VIDEO_SAMSUNG_EXYNOS4_IS? -- Thanks, Sylwester
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-04 02:10 +0100
Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-04 08:10 +0100
Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Holger Schurig <holgerschurig@gmail.com> - 2016-03-04 08:10 +0100
Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-03-04 12:10 +0100
Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-05 05:30 +0100
csiph-web