Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1349901

Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

From Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM
Date 2016-03-04 08:10 +0100
Message-ID <r8S25-2Yy-1@gated-at.bofh.it> (permalink)
References <r8MpH-7h0-1@gated-at.bofh.it> <r8S25-2Yy-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 04.03.2016 16:03, Holger Schurig wrote:
> Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
> 
>> +	depends on HAS_IOMEM	# For MFD_SYSCON
>                             ^^^^^^^^^^^^^^^^
> 
> I think this comment is not necessary, it's also highly unusual. On
> other words: other patches like this don't add such comments.
> 
> You can always use "git blame" to find out why some line has changed the
> way it changed ...

No problem, I can remove it. I thought it might be useful since this
dependency is not for the driver but for selected item.

Best regards,
Krzysztof

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] media: platform: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-04 02:10 +0100
  Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on  HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-04 08:10 +0100
  Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Holger Schurig <holgerschurig@gmail.com> - 2016-03-04 08:10 +0100
  Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on  HAS_IOMEM Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-03-04 12:10 +0100
    Re: [PATCH v2] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-05 05:30 +0100

csiph-web