Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1342958 > unrolled thread

Re: [PATCH] [Cleanup] x86: signal: unify the sigaltstack check with other arches

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] [Cleanup] x86: signal: unify the sigaltstack check with  other arches Ingo Molnar <mingo@kernel.org> - 2016-02-25 09:30 +0100
    Re: [PATCH] [Cleanup] x86: signal: unify the sigaltstack check with  other arches Stas Sergeev <stsp@list.ru> - 2016-02-25 13:20 +0100

#1342958 — Re: [PATCH] [Cleanup] x86: signal: unify the sigaltstack check with other arches

* Stas Sergeev <stsp@list.ru> wrote:

> Currently x86's get_sigframe() checks for "current->sas_ss_size"
> to determine whether there is a need to switch to sigaltstack.
> The common practice used by all other arches is to check for
> sas_ss_flags(sp) == 0
> 
> This patch makes the code consistent with other arches.
> The slight complexity of the patch is added by the optimization on
> !sigstack check that was requested by Andy Lutomirski: sas_ss_flags(sp)==0
> already implies that we are not on a sigstack, so the code is shuffled
> to avoid the duplicate checking.

So this changelog is missing an analysis about what effect this change will have 
on applications. Can any type of user-space code see a change in behavior? If yes, 
what will happen and is that effect desirable?

Thanks,

	Ingo

[toc] | [next] | [standalone]

#1343141

25.02.2016 11:25, Ingo Molnar пишет:
> 
> * Stas Sergeev <stsp@list.ru> wrote:
> 
>> Currently x86's get_sigframe() checks for "current->sas_ss_size"
>> to determine whether there is a need to switch to sigaltstack.
>> The common practice used by all other arches is to check for
>> sas_ss_flags(sp) == 0
>>
>> This patch makes the code consistent with other arches.
>> The slight complexity of the patch is added by the optimization on
>> !sigstack check that was requested by Andy Lutomirski: sas_ss_flags(sp)==0
>> already implies that we are not on a sigstack, so the code is shuffled
>> to avoid the duplicate checking.
> 
> So this changelog is missing an analysis about what effect this change will have 
> on applications. Can any type of user-space code see a change in behavior? If yes, 
> what will happen and is that effect desirable?
This is a clean-up, and as such, there is no visible effect.
If there is - it is a bug.
The purpose of this patch is only to unify the x86 code with
what all the other arches do. It was initially the part of the
rejected series, but now it is just a clean-up.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web