Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1342958

Re: [PATCH] [Cleanup] x86: signal: unify the sigaltstack check with other arches

Show all headers | View raw

* Stas Sergeev <stsp@list.ru> wrote:

> Currently x86's get_sigframe() checks for "current->sas_ss_size"
> to determine whether there is a need to switch to sigaltstack.
> The common practice used by all other arches is to check for
> sas_ss_flags(sp) == 0
> 
> This patch makes the code consistent with other arches.
> The slight complexity of the patch is added by the optimization on
> !sigstack check that was requested by Andy Lutomirski: sas_ss_flags(sp)==0
> already implies that we are not on a sigstack, so the code is shuffled
> to avoid the duplicate checking.

So this changelog is missing an analysis about what effect this change will have 
on applications. Can any type of user-space code see a change in behavior? If yes, 
what will happen and is that effect desirable?

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] [Cleanup] x86: signal: unify the sigaltstack check with  other arches Ingo Molnar <mingo@kernel.org> - 2016-02-25 09:30 +0100
  Re: [PATCH] [Cleanup] x86: signal: unify the sigaltstack check with  other arches Stas Sergeev <stsp@list.ru> - 2016-02-25 13:20 +0100

csiph-web