Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334120 > unrolled thread

[PATCH] staging: lustre: Fixed the parenthesis

Started byShalin Mehta <shalinmehta85@gmail.com>
First post2016-02-15 04:40 +0100
Last post2016-02-19 11:30 +0100
Articles 6 — 5 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: lustre: Fixed the parenthesis Shalin Mehta <shalinmehta85@gmail.com> - 2016-02-15 04:40 +0100
    Re: [PATCH] staging: lustre: Fixed the parenthesis Greg KH <gregkh@linuxfoundation.org> - 2016-02-16 03:30 +0100
      Re: [PATCH] staging: lustre: Fixed the parenthesis "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-02-16 03:50 +0100
    Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-02-16 04:00 +0100
      Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis shalin mehta <shalinmehta85@gmail.com> - 2016-02-17 07:40 +0100
        Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-19 11:30 +0100

#1334120 — [PATCH] staging: lustre: Fixed the parenthesis

FromShalin Mehta <shalinmehta85@gmail.com>
Date2016-02-15 04:40 +0100
Subject[PATCH] staging: lustre: Fixed the parenthesis
Message-ID<r2iaZ-3Gn-5@gated-at.bofh.it>
The parentehsis are fixed in the macro for the ldlm lock to set and
clear the flags.

Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
---
 drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
index 0d3ed87..4f9e9ad 100644
--- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
+++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
@@ -365,10 +365,10 @@
 #define LDLM_TEST_FLAG(_l, _b)        (((_l)->l_flags & (_b)) != 0)
 
 /** set a ldlm_lock flag bit */
-#define LDLM_SET_FLAG(_l, _b)         (((_l)->l_flags |= (_b))
+#define LDLM_SET_FLAG(_l, _b)         ((_l)->l_flags |= (_b))
 
 /** clear a ldlm_lock flag bit */
-#define LDLM_CLEAR_FLAG(_l, _b)       (((_l)->l_flags &= ~(_b))
+#define LDLM_CLEAR_FLAG(_l, _b)       ((_l)->l_flags &= ~(_b))
 
 /** Mask of flags inherited from parent lock when doing intents. */
 #define LDLM_INHERIT_FLAGS            LDLM_FL_INHERIT_MASK
-- 
1.9.1

[toc] | [next] | [standalone]

#1334945

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-02-16 03:30 +0100
Message-ID<r2DyO-1ku-9@gated-at.bofh.it>
In reply to#1334120
On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.

"fixed" in what way?  Did you test-build this patch?  Also, you
mispelled a word here...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1334964

From"Drokin, Oleg" <oleg.drokin@intel.com>
Date2016-02-16 03:50 +0100
Message-ID<r2DSb-1uE-21@gated-at.bofh.it>
In reply to#1334945
On Feb 15, 2016, at 9:28 PM, Greg KH wrote:

> On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
> 
> "fixed" in what way?  Did you test-build this patch?  Also, you
> mispelled a word here…

The fix in the patch is to make sure number of parenthesis matches, as is
it appears there's one more opening one than the closing.

The original patch that add this had an error somehow, but back then none
of the users were later introduced, so the bug is "hidden" until
first user actually appears.

Compiles work with or without this fix as the result (I also just checked
just to be sure).

[toc] | [prev] | [next] | [standalone]

#1334969 — Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

From"Drokin, Oleg" <oleg.drokin@intel.com>
Date2016-02-16 04:00 +0100
SubjectRe: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
Message-ID<r2E1Q-1z0-15@gated-at.bofh.it>
In reply to#1334120
On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:

> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.
> 
> Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
> ---
> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> index 0d3ed87..4f9e9ad 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> @@ -365,10 +365,10 @@
> #define LDLM_TEST_FLAG(_l, _b)        (((_l)->l_flags & (_b)) != 0)
> 
> /** set a ldlm_lock flag bit */
> -#define LDLM_SET_FLAG(_l, _b)         (((_l)->l_flags |= (_b))
> +#define LDLM_SET_FLAG(_l, _b)         ((_l)->l_flags |= (_b))
> 
> /** clear a ldlm_lock flag bit */
> -#define LDLM_CLEAR_FLAG(_l, _b)       (((_l)->l_flags &= ~(_b))
> +#define LDLM_CLEAR_FLAG(_l, _b)       ((_l)->l_flags &= ~(_b))
> 
> /** Mask of flags inherited from parent lock when doing intents. */
> #define LDLM_INHERIT_FLAGS            LDLM_FL_INHERIT_MASK

Acked-by: Oleg Drokin <oleg.drokin@intel.com>

[toc] | [prev] | [next] | [standalone]

#1336078 — Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

Fromshalin mehta <shalinmehta85@gmail.com>
Date2016-02-17 07:40 +0100
SubjectRe: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
Message-ID<r33Wh-2z6-13@gated-at.bofh.it>
In reply to#1334969
Hello,

Should I send this patch again due the spelling mistake in the patch
description?

Thanks,
Shalin

On Mon, Feb 15, 2016 at 6:51 PM, Drokin, Oleg <oleg.drokin@intel.com> wrote:
>
> On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:
>
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
>>
>> Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> index 0d3ed87..4f9e9ad 100644
>> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> @@ -365,10 +365,10 @@
>> #define LDLM_TEST_FLAG(_l, _b)        (((_l)->l_flags & (_b)) != 0)
>>
>> /** set a ldlm_lock flag bit */
>> -#define LDLM_SET_FLAG(_l, _b)         (((_l)->l_flags |= (_b))
>> +#define LDLM_SET_FLAG(_l, _b)         ((_l)->l_flags |= (_b))
>>
>> /** clear a ldlm_lock flag bit */
>> -#define LDLM_CLEAR_FLAG(_l, _b)       (((_l)->l_flags &= ~(_b))
>> +#define LDLM_CLEAR_FLAG(_l, _b)       ((_l)->l_flags &= ~(_b))
>>
>> /** Mask of flags inherited from parent lock when doing intents. */
>> #define LDLM_INHERIT_FLAGS            LDLM_FL_INHERIT_MASK
>
> Acked-by: Oleg Drokin <oleg.drokin@intel.com>
>

[toc] | [prev] | [next] | [standalone]

#1338036 — Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

FromDan Carpenter <dan.carpenter@oracle.com>
Date2016-02-19 11:30 +0100
SubjectRe: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis
Message-ID<r3QtZ-3Bd-35@gated-at.bofh.it>
In reply to#1336078
On Tue, Feb 16, 2016 at 10:39:05PM -0800, shalin mehta wrote:
> Hello,
> 
> Should I send this patch again due the spelling mistake in the patch
> description?
> 


Yes.  And put what Oleg Drokin said about it worked because there were
no users in the changelog.

regards,
dan carpenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web