Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336078

Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

Show all headers | View raw

Hello,

Should I send this patch again due the spelling mistake in the patch
description?

Thanks,
Shalin

On Mon, Feb 15, 2016 at 6:51 PM, Drokin, Oleg <oleg.drokin@intel.com> wrote:
>
> On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:
>
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
>>
>> Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> index 0d3ed87..4f9e9ad 100644
>> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
>> @@ -365,10 +365,10 @@
>> #define LDLM_TEST_FLAG(_l, _b)        (((_l)->l_flags & (_b)) != 0)
>>
>> /** set a ldlm_lock flag bit */
>> -#define LDLM_SET_FLAG(_l, _b)         (((_l)->l_flags |= (_b))
>> +#define LDLM_SET_FLAG(_l, _b)         ((_l)->l_flags |= (_b))
>>
>> /** clear a ldlm_lock flag bit */
>> -#define LDLM_CLEAR_FLAG(_l, _b)       (((_l)->l_flags &= ~(_b))
>> +#define LDLM_CLEAR_FLAG(_l, _b)       ((_l)->l_flags &= ~(_b))
>>
>> /** Mask of flags inherited from parent lock when doing intents. */
>> #define LDLM_INHERIT_FLAGS            LDLM_FL_INHERIT_MASK
>
> Acked-by: Oleg Drokin <oleg.drokin@intel.com>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: Fixed the parenthesis Shalin Mehta <shalinmehta85@gmail.com> - 2016-02-15 04:40 +0100
  Re: [PATCH] staging: lustre: Fixed the parenthesis Greg KH <gregkh@linuxfoundation.org> - 2016-02-16 03:30 +0100
    Re: [PATCH] staging: lustre: Fixed the parenthesis "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-02-16 03:50 +0100
  Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-02-16 04:00 +0100
    Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis shalin mehta <shalinmehta85@gmail.com> - 2016-02-17 07:40 +0100
      Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-19 11:30 +0100

csiph-web