Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1334964

Re: [PATCH] staging: lustre: Fixed the parenthesis

Show all headers | View raw

On Feb 15, 2016, at 9:28 PM, Greg KH wrote:

> On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
> 
> "fixed" in what way?  Did you test-build this patch?  Also, you
> mispelled a word here…

The fix in the patch is to make sure number of parenthesis matches, as is
it appears there's one more opening one than the closing.

The original patch that add this had an error somehow, but back then none
of the users were later introduced, so the bug is "hidden" until
first user actually appears.

Compiles work with or without this fix as the result (I also just checked
just to be sure).

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: Fixed the parenthesis Shalin Mehta <shalinmehta85@gmail.com> - 2016-02-15 04:40 +0100
  Re: [PATCH] staging: lustre: Fixed the parenthesis Greg KH <gregkh@linuxfoundation.org> - 2016-02-16 03:30 +0100
    Re: [PATCH] staging: lustre: Fixed the parenthesis "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-02-16 03:50 +0100
  Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-02-16 04:00 +0100
    Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis shalin mehta <shalinmehta85@gmail.com> - 2016-02-17 07:40 +0100
      Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-19 11:30 +0100

csiph-web