Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1332514 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2016-02-12 05:20 +0100 |
| Last post | 2016-02-15 07:40 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] regulator: Rename files for max77686 and max77802 drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-12 05:20 +0100
Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-14 08:00 +0100
Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-15 15:50 +0100
Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers Andi Shyti <andi.shyti@samsung.com> - 2016-02-15 07:40 +0100
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-02-12 05:20 +0100 |
| Subject | [PATCH] regulator: Rename files for max77686 and max77802 drivers |
| Message-ID | <r1dn5-1PZ-13@gated-at.bofh.it> |
The max77686 and max77802 regulator drivers are for sub-devices of a MFD
driver for some PMIC blocks. But the same object file name (max77686.o)
was used for both the common MFD driver and the max77686 regulator one.
This confuses kbuild if both drivers are built as module causing the MFD
driver to not be copied when installing the modules.
Also, max77{686,802} are a quite generic name for MFD subdevices drivers
so it is better to rename them to max77{686,802}-regulator like it's the
case for most regulator drivers.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
MAINTAINERS | 2 +-
drivers/regulator/Makefile | 4 ++--
drivers/regulator/{max77686.c => max77686-regulator.c} | 0
drivers/regulator/{max77802.c => max77802-regulator.c} | 0
4 files changed, 3 insertions(+), 3 deletions(-)
rename drivers/regulator/{max77686.c => max77686-regulator.c} (100%)
rename drivers/regulator/{max77802.c => max77802-regulator.c} (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index 97b99f24ea53..863eb59e101b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6904,7 +6904,7 @@ MAXIM MAX77802 MULTIFUNCTION PMIC DEVICE DRIVERS
M: Javier Martinez Canillas <javier@osg.samsung.com>
L: linux-kernel@vger.kernel.org
S: Supported
-F: drivers/*/*max77802.c
+F: drivers/*/*max77802*.c
F: Documentation/devicetree/bindings/*/*max77802.txt
F: include/dt-bindings/*/*max77802.h
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 348cfd727350..bd6ae0ccd2e9 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -55,9 +55,9 @@ obj-$(CONFIG_REGULATOR_MAX8952) += max8952.o
obj-$(CONFIG_REGULATOR_MAX8973) += max8973-regulator.o
obj-$(CONFIG_REGULATOR_MAX8997) += max8997.o
obj-$(CONFIG_REGULATOR_MAX8998) += max8998.o
-obj-$(CONFIG_REGULATOR_MAX77686) += max77686.o
+obj-$(CONFIG_REGULATOR_MAX77686) += max77686-regulator.o
obj-$(CONFIG_REGULATOR_MAX77693) += max77693.o
-obj-$(CONFIG_REGULATOR_MAX77802) += max77802.o
+obj-$(CONFIG_REGULATOR_MAX77802) += max77802-regulator.o
obj-$(CONFIG_REGULATOR_MC13783) += mc13783-regulator.o
obj-$(CONFIG_REGULATOR_MC13892) += mc13892-regulator.o
obj-$(CONFIG_REGULATOR_MC13XXX_CORE) += mc13xxx-regulator-core.o
diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686-regulator.c
similarity index 100%
rename from drivers/regulator/max77686.c
rename to drivers/regulator/max77686-regulator.c
diff --git a/drivers/regulator/max77802.c b/drivers/regulator/max77802-regulator.c
similarity index 100%
rename from drivers/regulator/max77802.c
rename to drivers/regulator/max77802-regulator.c
--
2.5.0
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-02-14 08:00 +0100 |
| Message-ID | <r1YP1-7Co-15@gated-at.bofh.it> |
| In reply to | #1332514 |
W dniu 12.02.2016 o 13:14, Javier Martinez Canillas pisze:
> The max77686 and max77802 regulator drivers are for sub-devices of a MFD
> driver for some PMIC blocks. But the same object file name (max77686.o)
> was used for both the common MFD driver and the max77686 regulator one.
>
> This confuses kbuild if both drivers are built as module causing the MFD
> driver to not be copied when installing the modules.
>
> Also, max77{686,802} are a quite generic name for MFD subdevices drivers
> so it is better to rename them to max77{686,802}-regulator like it's the
> case for most regulator drivers.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> MAINTAINERS | 2 +-
> drivers/regulator/Makefile | 4 ++--
> drivers/regulator/{max77686.c => max77686-regulator.c} | 0
> drivers/regulator/{max77802.c => max77802-regulator.c} | 0
> 4 files changed, 3 insertions(+), 3 deletions(-)
> rename drivers/regulator/{max77686.c => max77686-regulator.c} (100%)
> rename drivers/regulator/{max77802.c => max77802-regulator.c} (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 97b99f24ea53..863eb59e101b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6904,7 +6904,7 @@ MAXIM MAX77802 MULTIFUNCTION PMIC DEVICE DRIVERS
> M: Javier Martinez Canillas <javier@osg.samsung.com>
> L: linux-kernel@vger.kernel.org
> S: Supported
> -F: drivers/*/*max77802.c
> +F: drivers/*/*max77802*.c
> F: Documentation/devicetree/bindings/*/*max77802.txt
> F: include/dt-bindings/*/*max77802.h
Looks fine, but can you also update the max77686 entry with extended
wildcard?
Best regards,
Krzysztof
[toc] | [prev] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-02-15 15:50 +0100 |
| Message-ID | <r2sDo-2lG-33@gated-at.bofh.it> |
| In reply to | #1333442 |
Hello Krzysztof, On 02/14/2016 03:53 AM, Krzysztof Kozlowski wrote: [snip] >> +++ b/MAINTAINERS >> @@ -6904,7 +6904,7 @@ MAXIM MAX77802 MULTIFUNCTION PMIC DEVICE DRIVERS >> M: Javier Martinez Canillas <javier@osg.samsung.com> >> L: linux-kernel@vger.kernel.org >> S: Supported >> -F: drivers/*/*max77802.c >> +F: drivers/*/*max77802*.c >> F: Documentation/devicetree/bindings/*/*max77802.txt >> F: include/dt-bindings/*/*max77802.h > > Looks fine, but can you also update the max77686 entry with extended > wildcard? > This has already been picked by Mark so I posted an incremental patch: https://patchwork.kernel.org/patch/8315731/ > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
[toc] | [prev] | [next] | [standalone]
| From | Andi Shyti <andi.shyti@samsung.com> |
|---|---|
| Date | 2016-02-15 07:40 +0100 |
| Message-ID | <r2kZb-5E7-3@gated-at.bofh.it> |
| In reply to | #1332514 |
On Fri, Feb 12, 2016 at 01:14:23AM -0300, Javier Martinez Canillas wrote:
> The max77686 and max77802 regulator drivers are for sub-devices of a MFD
> driver for some PMIC blocks. But the same object file name (max77686.o)
> was used for both the common MFD driver and the max77686 regulator one.
>
> This confuses kbuild if both drivers are built as module causing the MFD
> driver to not be copied when installing the modules.
>
> Also, max77{686,802} are a quite generic name for MFD subdevices drivers
> so it is better to rename them to max77{686,802}-regulator like it's the
> case for most regulator drivers.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Looks good.
Reviewed-by: Andi Shyti <andi.shyti@samsung.com>
Andi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web