Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers

From	Andi Shyti <andi.shyti@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers
Date	2016-02-15 07:40 +0100
Message-ID	<r2kZb-5E7-3@gated-at.bofh.it> (permalink)
References	<r1dn5-1PZ-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 12, 2016 at 01:14:23AM -0300, Javier Martinez Canillas wrote:
> The max77686 and max77802 regulator drivers are for sub-devices of a MFD
> driver for some PMIC blocks. But the same object file name (max77686.o)
> was used for both the common MFD driver and the max77686 regulator one.
> 
> This confuses kbuild if both drivers are built as module causing the MFD
> driver to not be copied when installing the modules.
> 
> Also, max77{686,802} are a quite generic name for MFD subdevices drivers
> so it is better to rename them to max77{686,802}-regulator like it's the
> case for most regulator drivers.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Looks good.

Reviewed-by: Andi Shyti <andi.shyti@samsung.com>

Andi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: Rename files for max77686 and max77802 drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-12 05:20 +0100
  Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-14 08:00 +0100
    Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-15 15:50 +0100
  Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers Andi Shyti <andi.shyti@samsung.com> - 2016-02-15 07:40 +0100

csiph-web