Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1333442

Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers

Show all headers | View raw

W dniu 12.02.2016 o 13:14, Javier Martinez Canillas pisze:
> The max77686 and max77802 regulator drivers are for sub-devices of a MFD
> driver for some PMIC blocks. But the same object file name (max77686.o)
> was used for both the common MFD driver and the max77686 regulator one.
> 
> This confuses kbuild if both drivers are built as module causing the MFD
> driver to not be copied when installing the modules.
> 
> Also, max77{686,802} are a quite generic name for MFD subdevices drivers
> so it is better to rename them to max77{686,802}-regulator like it's the
> case for most regulator drivers.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
>  MAINTAINERS                                            | 2 +-
>  drivers/regulator/Makefile                             | 4 ++--
>  drivers/regulator/{max77686.c => max77686-regulator.c} | 0
>  drivers/regulator/{max77802.c => max77802-regulator.c} | 0
>  4 files changed, 3 insertions(+), 3 deletions(-)
>  rename drivers/regulator/{max77686.c => max77686-regulator.c} (100%)
>  rename drivers/regulator/{max77802.c => max77802-regulator.c} (100%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 97b99f24ea53..863eb59e101b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6904,7 +6904,7 @@ MAXIM MAX77802 MULTIFUNCTION PMIC DEVICE DRIVERS
>  M:	Javier Martinez Canillas <javier@osg.samsung.com>
>  L:	linux-kernel@vger.kernel.org
>  S:	Supported
> -F:	drivers/*/*max77802.c
> +F:	drivers/*/*max77802*.c
>  F:	Documentation/devicetree/bindings/*/*max77802.txt
>  F:	include/dt-bindings/*/*max77802.h

Looks fine, but can you also update the max77686 entry with extended
wildcard?

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: Rename files for max77686 and max77802 drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-12 05:20 +0100
  Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-14 08:00 +0100
    Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-15 15:50 +0100
  Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers Andi Shyti <andi.shyti@samsung.com> - 2016-02-15 07:40 +0100

csiph-web