Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1329658 > unrolled thread

Re: [PATCH v3 5/6] dts: ipq4019: Add support for IPQ4019 DK01 board

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 5/6] dts: ipq4019: Add support for IPQ4019 DK01 board Stephen Boyd <sboyd@codeaurora.org> - 2016-02-08 23:50 +0100
    Re: [PATCH v3 5/6] dts: ipq4019: Add support for IPQ4019 DK01 board Matthew McClintock <mmcclint@codeaurora.org> - 2016-02-16 21:50 +0100
      Re: [PATCH v3 5/6] dts: ipq4019: Add support for IPQ4019 DK01 board Stephen Boyd <sboyd@codeaurora.org> - 2016-02-19 03:50 +0100

#1329658 — Re: [PATCH v3 5/6] dts: ipq4019: Add support for IPQ4019 DK01 board

On 11/19, Matthew McClintock wrote:
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1";
> +	compatible = "qcom,ipq4019";
> +
> +	clocks {
> +                xo: xo {
> +                        compatible = "fixed-clock";
> +                        clock-frequency = <48000000>;
> +                        #clock-cells = <0>;
> +                };
> +	};

Is there a reason the xo is here and the sleep clk is in the SoC
dtsi file? Both are board clocks so I would think they would be
added in the same place.

> +
> +	soc {
> +
> +
> +		timer {
> +			compatible = "arm,armv7-timer";
> +			interrupts = <1 2 0xf08>,
> +				     <1 3 0xf08>,
> +				     <1 4 0xf08>,
> +				     <1 1 0xf08>;
> +			clock-frequency = <48000000>;
> +		};

The timer shouldn't be part of the SoC node (it has no reg property).

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [next] | [standalone]

#1335827

On Feb 8, 2016, at 4:43 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> 
> On 11/19, Matthew McClintock wrote:
>> +
>> +/ {
>> +	model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1";
>> +	compatible = "qcom,ipq4019";
>> +
>> +	clocks {
>> +                xo: xo {
>> +                        compatible = "fixed-clock";
>> +                        clock-frequency = <48000000>;
>> +                        #clock-cells = <0>;
>> +                };
>> +	};
> 
> Is there a reason the xo is here and the sleep clk is in the SoC
> dtsi file? Both are board clocks so I would think they would be
> added in the same place.

I’m a little bit confused and I wanted to confirm. I can see the xo clock is on the board itself. However, the sleep_clk is not, can you clarify why they would both be in the same place?

-M

[toc] | [prev] | [next] | [standalone]

#1337847

On 02/16, Matthew McClintock wrote:
> On Feb 8, 2016, at 4:43 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > 
> > On 11/19, Matthew McClintock wrote:
> >> +
> >> +/ {
> >> +	model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1";
> >> +	compatible = "qcom,ipq4019";
> >> +
> >> +	clocks {
> >> +                xo: xo {
> >> +                        compatible = "fixed-clock";
> >> +                        clock-frequency = <48000000>;
> >> +                        #clock-cells = <0>;
> >> +                };
> >> +	};
> > 
> > Is there a reason the xo is here and the sleep clk is in the SoC
> > dtsi file? Both are board clocks so I would think they would be
> > added in the same place.
> 
> I’m a little bit confused and I wanted to confirm. I can see the xo clock is on the board itself. However, the sleep_clk is not, can you clarify why they would both be in the same place?
> 

The sleep clk is typically a pin on the SoC package. Look at your
schematic. Same goes for the XO.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web