Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241216 > unrolled thread

Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

Started bysugar <sugar.zhang@rock-chips.com>
First post2015-10-07 10:10 +0200
Last post2015-10-08 06:10 +0200
Articles 10 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-07 10:10 +0200
    Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support Mark Brown <broonie@kernel.org> - 2015-10-07 11:30 +0200
      Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support Mark Brown <broonie@kernel.org> - 2015-10-07 11:50 +0200
        Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-07 12:10 +0200
    Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Caleb Crome <caleb@crome.org> - 2015-10-07 15:10 +0200
      Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels  capture and lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-08 03:50 +0200
        Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Caleb Crome <caleb@crome.org> - 2015-10-08 04:40 +0200
          Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels  capture and lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-08 04:50 +0200
            Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Caleb Crome <caleb@crome.org> - 2015-10-08 05:20 +0200
              Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels  capture and lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-08 06:10 +0200

#1241216 — Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

Fromsugar <sugar.zhang@rock-chips.com>
Date2015-10-07 10:10 +0200
SubjectRe: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support
Message-ID<qgRXr-7nh-9@gated-at.bofh.it>
Sorry for late reply, we were in the National Day Holiday.

在 10/1/2015 02:46, Mark Brown 写道:
> On Mon, Sep 28, 2015 at 04:16:12PM +0800, sugar wrote:
>> 在 9/24/2015 00:24, Mark Brown 写道:
>
>>> My initial thought here is that the machine driver should be responsible
>>> for setting this and then the DAI driver should check to see if
>>> symmetric_rates are in use and configure itself appropriately.  Is there
>>> a reason why this won't work here?
>
>> It's for i2s ip configuration, in the most situation, there is no need
>> to use this property, except one case:
>
>> In order to save gpio pins for other function use, we may use single
>> lrck(tx or rx) pin. of course, it depends on product design. when in i2s
>> slave mode, we need to configure this to share lrck with tx/rx inside i2s
>> logic.
>
>> symmetric_rates flag works fine on rockchip platform, but it can't cover the
>> above case.
>
>> Do you have any suggestion about this or maybe there is no need to upstream
>> this special part?
>
> What makes you say that the symmetric_rates flag can't be used to cover
> this case?  What you describe above is hte normal reason for needing to
> enforce symmetric_rates.  The driver should be able to check if the flag
> has been set just as well as the core is.
>

Got it, How about the following modify?

if (dai->symmetric_rates)
	regmap_update_bits(i2s->regmap, I2S_CKR,
                            I2S_CKR_TRCM_MASK,
                            I2S_CKR_TRCM(val));


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1241286

FromMark Brown <broonie@kernel.org>
Date2015-10-07 11:30 +0200
Message-ID<qgTcS-DX-27@gated-at.bofh.it>
In reply to#1241216

[Multipart message — attachments visible in raw view] — view raw

On Wed, Oct 07, 2015 at 04:01:38PM +0800, sugar wrote:
> 在 10/1/2015 02:46, Mark Brown 写道:

> >What makes you say that the symmetric_rates flag can't be used to cover
> >this case?  What you describe above is hte normal reason for needing to
> >enforce symmetric_rates.  The driver should be able to check if the flag
> >has been set just as well as the core is.

> Got it, How about the following modify?

> if (dai->symmetric_rates)
> 	regmap_update_bits(i2s->regmap, I2S_CKR,
>                            I2S_CKR_TRCM_MASK,
>                            I2S_CKR_TRCM(val));

Yes, something like that.  You'll need to check both links in the DAI
and the DAI link itself rather than just your own DAI but we should have
a helper function for that - I'll add one, look out for a patch shortly.

[toc] | [prev] | [next] | [standalone]

#1241298

FromMark Brown <broonie@kernel.org>
Date2015-10-07 11:50 +0200
Message-ID<qgTwe-10x-21@gated-at.bofh.it>
In reply to#1241286

[Multipart message — attachments visible in raw view] — view raw

On Wed, Oct 07, 2015 at 10:27:14AM +0100, Mark Brown wrote:
> On Wed, Oct 07, 2015 at 04:01:38PM +0800, sugar wrote:

> > if (dai->symmetric_rates)
> > 	regmap_update_bits(i2s->regmap, I2S_CKR,
> >                            I2S_CKR_TRCM_MASK,
> >                            I2S_CKR_TRCM(val));

> Yes, something like that.  You'll need to check both links in the DAI
> and the DAI link itself rather than just your own DAI but we should have
> a helper function for that - I'll add one, look out for a patch shortly.

Actually no, now I look at the code you probably want to just clone the
check from soc_pcm_apply_symmetry() so have that be:

	struct snd_soc_pcm_runtime *rtd = substream->private_data;

	if (rtd->dai_link->symmetrict_rates) {
	}

instead.

[toc] | [prev] | [next] | [standalone]

#1241311

Fromsugar <sugar.zhang@rock-chips.com>
Date2015-10-07 12:10 +0200
Message-ID<qgTPD-1CH-83@gated-at.bofh.it>
In reply to#1241298

在 10/7/2015 17:39, Mark Brown 写道:
> On Wed, Oct 07, 2015 at 10:27:14AM +0100, Mark Brown wrote:
>> On Wed, Oct 07, 2015 at 04:01:38PM +0800, sugar wrote:
>
>>> if (dai->symmetric_rates)
>>> 	regmap_update_bits(i2s->regmap, I2S_CKR,
>>>                             I2S_CKR_TRCM_MASK,
>>>                             I2S_CKR_TRCM(val));
>
>> Yes, something like that.  You'll need to check both links in the DAI
>> and the DAI link itself rather than just your own DAI but we should have
>> a helper function for that - I'll add one, look out for a patch shortly.
>
> Actually no, now I look at the code you probably want to just clone the
> check from soc_pcm_apply_symmetry() so have that be:
>
> 	struct snd_soc_pcm_runtime *rtd = substream->private_data;
>
> 	if (rtd->dai_link->symmetrict_rates) {
> 	}
>
> instead.
>

OK, this will be done in patchset v2, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241469 — Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

FromCaleb Crome <caleb@crome.org>
Date2015-10-07 15:10 +0200
SubjectRe: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support
Message-ID<qgWDL-5In-17@gated-at.bofh.it>
In reply to#1241216
Hi sugar,
   Can the rockchip support more than 8 channels?  Ideally, we would like to capture 16 channels and playback 16 channels simultaneously.  

Thanks,  Caleb 

Sent from my iPhone

> On Oct 7, 2015, at 1:01 AM, sugar <sugar.zhang@rock-chips.com> wrote:
> 
> Sorry for late reply, we were in the National Day Holiday.
> 
>> 在 10/1/2015 02:46, Mark Brown 写道:
>>> On Mon, Sep 28, 2015 at 04:16:12PM +0800, sugar wrote:
>>> 在 9/24/2015 00:24, Mark Brown 写道:
>> 
>>>> My initial thought here is that the machine driver should be responsible
>>>> for setting this and then the DAI driver should check to see if
>>>> symmetric_rates are in use and configure itself appropriately.  Is there
>>>> a reason why this won't work here?
>> 
>>> It's for i2s ip configuration, in the most situation, there is no need
>>> to use this property, except one case:
>> 
>>> In order to save gpio pins for other function use, we may use single
>>> lrck(tx or rx) pin. of course, it depends on product design. when in i2s
>>> slave mode, we need to configure this to share lrck with tx/rx inside i2s
>>> logic.
>> 
>>> symmetric_rates flag works fine on rockchip platform, but it can't cover the
>>> above case.
>> 
>>> Do you have any suggestion about this or maybe there is no need to upstream
>>> this special part?
>> 
>> What makes you say that the symmetric_rates flag can't be used to cover
>> this case?  What you describe above is hte normal reason for needing to
>> enforce symmetric_rates.  The driver should be able to check if the flag
>> has been set just as well as the core is.
> 
> Got it, How about the following modify?
> 
> if (dai->symmetric_rates)
>    regmap_update_bits(i2s->regmap, I2S_CKR,
>                           I2S_CKR_TRCM_MASK,
>                           I2S_CKR_TRCM(val));
> 
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241923 — Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

Fromsugar <sugar.zhang@rock-chips.com>
Date2015-10-08 03:50 +0200
SubjectRe: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support
Message-ID<qh8vf-5JS-1@gated-at.bofh.it>
In reply to#1241469
Hi Caleb,

we haven't support 16 channels capture and playback yet, would you mind 
to detail the use case? if must, we may support this feature on next 
generation chip.

在 10/7/2015 21:04, Caleb Crome 写道:
> Hi sugar,
>     Can the rockchip support more than 8 channels?  Ideally, we would like to capture 16 channels and playback 16 channels simultaneously.
>
> Thanks,  Caleb
>
> Sent from my iPhone

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241930 — Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

FromCaleb Crome <caleb@crome.org>
Date2015-10-08 04:40 +0200
SubjectRe: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support
Message-ID<qh9hD-6Ze-1@gated-at.bofh.it>
In reply to#1241923
We make microphone arrays with lots of microphones.  Some as few as 2, many with 7 channels, and a few with 14 or more.  

Can you support 8 channels with 32 bits/sample?  That would work, we can just set the codecs for 16-bit samples, which would be 256 bits/frame.

Hope you had a great golden week holiday!

Thanks,  
    Caleb Crome




Sent from my iPhone

> On Oct 7, 2015, at 6:47 PM, sugar <sugar.zhang@rock-chips.com> wrote:
> 
> Hi Caleb,
> 
> we haven't support 16 channels capture and playback yet, would you mind to detail the use case? if must, we may support this feature on next generation chip.
> 
>> 在 10/7/2015 21:04, Caleb Crome 写道:
>> Hi sugar,
>>    Can the rockchip support more than 8 channels?  Ideally, we would like to capture 16 channels and playback 16 channels simultaneously.
>> 
>> Thanks,  Caleb
>> 
>> Sent from my iPhone
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241936 — Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

Fromsugar <sugar.zhang@rock-chips.com>
Date2015-10-08 04:50 +0200
SubjectRe: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support
Message-ID<qh9rk-7aQ-11@gated-at.bofh.it>
In reply to#1241930
Yes, we can support 8 channels with 32bits/sample, thanks.

在 10/8/2015 10:36, Caleb Crome 写道:
> We make microphone arrays with lots of microphones.  Some as few as 2, many with 7 channels, and a few with 14 or more.
>
> Can you support 8 channels with 32 bits/sample?  That would work, we can just set the codecs for 16-bit samples, which would be 256 bits/frame.
>
> Hope you had a great golden week holiday!
>
> Thanks,
>      Caleb Crome
>
>
>
>
> Sent from my iPhone

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241940 — Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

FromCaleb Crome <caleb@crome.org>
Date2015-10-08 05:20 +0200
SubjectRe: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support
Message-ID<qh9Um-7XH-5@gated-at.bofh.it>
In reply to#1241936
 That will work!  Do all your cortex-a parts support that?

Thanks, Caleb 
Sent from my iPhone

> On Oct 7, 2015, at 7:44 PM, sugar <sugar.zhang@rock-chips.com> wrote:
> 
> Yes, we can support 8 channels with 32bits/sample, thanks.
> 
>> 在 10/8/2015 10:36, Caleb Crome 写道:
>> We make microphone arrays with lots of microphones.  Some as few as 2, many with 7 channels, and a few with 14 or more.
>> 
>> Can you support 8 channels with 32 bits/sample?  That would work, we can just set the codecs for 16-bit samples, which would be 256 bits/frame.
>> 
>> Hope you had a great golden week holiday!
>> 
>> Thanks,
>>     Caleb Crome
>> 
>> 
>> 
>> 
>> Sent from my iPhone
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1241955 — Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

Fromsugar <sugar.zhang@rock-chips.com>
Date2015-10-08 06:10 +0200
SubjectRe: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support
Message-ID<qhaGJ-F6-1@gated-at.bofh.it>
In reply to#1241940
Only the new design support 8 channels capture now, the others support 2 
channels capture. but all of them support 32bits/sample.

On 10/8/2015 11:19, Caleb Crome wrote:
>   That will work!  Do all your cortex-a parts support that?
>
> Thanks, Caleb
> Sent from my iPhone

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web