Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support
Date	2015-10-07 11:30 +0200
Message-ID	<qgTcS-DX-27@gated-at.bofh.it> (permalink)
References	(1 earlier) <qbJea-Dl-7@gated-at.bofh.it> <qbV5D-13M-1@gated-at.bofh.it> <qdBPc-55-19@gated-at.bofh.it> <qeuBX-4Wa-1@gated-at.bofh.it> <qgRXr-7nh-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Oct 07, 2015 at 04:01:38PM +0800, sugar wrote:
> 在 10/1/2015 02:46, Mark Brown 写道:

> >What makes you say that the symmetric_rates flag can't be used to cover
> >this case?  What you describe above is hte normal reason for needing to
> >enforce symmetric_rates.  The driver should be able to check if the flag
> >has been set just as well as the core is.

> Got it, How about the following modify?

> if (dai->symmetric_rates)
> 	regmap_update_bits(i2s->regmap, I2S_CKR,
>                            I2S_CKR_TRCM_MASK,
>                            I2S_CKR_TRCM(val));

Yes, something like that.  You'll need to check both links in the DAI
and the DAI link itself rather than just your own DAI but we should have
a helper function for that - I'll add one, look out for a patch shortly.

Thread

Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-07 10:10 +0200
  Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support Mark Brown <broonie@kernel.org> - 2015-10-07 11:30 +0200
    Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support Mark Brown <broonie@kernel.org> - 2015-10-07 11:50 +0200
      Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-07 12:10 +0200
  Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Caleb Crome <caleb@crome.org> - 2015-10-07 15:10 +0200
    Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels  capture and lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-08 03:50 +0200
      Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Caleb Crome <caleb@crome.org> - 2015-10-08 04:40 +0200
        Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels  capture and lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-08 04:50 +0200
          Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Caleb Crome <caleb@crome.org> - 2015-10-08 05:20 +0200
            Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels  capture and lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-08 06:10 +0200

csiph-web