Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1241298

Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support
Date 2015-10-07 11:50 +0200
Message-ID <qgTwe-10x-21@gated-at.bofh.it> (permalink)
References (2 earlier) <qbV5D-13M-1@gated-at.bofh.it> <qdBPc-55-19@gated-at.bofh.it> <qeuBX-4Wa-1@gated-at.bofh.it> <qgRXr-7nh-9@gated-at.bofh.it> <qgTcS-DX-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Wed, Oct 07, 2015 at 10:27:14AM +0100, Mark Brown wrote:
> On Wed, Oct 07, 2015 at 04:01:38PM +0800, sugar wrote:

> > if (dai->symmetric_rates)
> > 	regmap_update_bits(i2s->regmap, I2S_CKR,
> >                            I2S_CKR_TRCM_MASK,
> >                            I2S_CKR_TRCM(val));

> Yes, something like that.  You'll need to check both links in the DAI
> and the DAI link itself rather than just your own DAI but we should have
> a helper function for that - I'll add one, look out for a patch shortly.

Actually no, now I look at the code you probably want to just clone the
check from soc_pcm_apply_symmetry() so have that be:

	struct snd_soc_pcm_runtime *rtd = substream->private_data;

	if (rtd->dai_link->symmetrict_rates) {
	}

instead.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-07 10:10 +0200
  Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support Mark Brown <broonie@kernel.org> - 2015-10-07 11:30 +0200
    Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support Mark Brown <broonie@kernel.org> - 2015-10-07 11:50 +0200
      Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and  lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-07 12:10 +0200
  Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Caleb Crome <caleb@crome.org> - 2015-10-07 15:10 +0200
    Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels  capture and lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-08 03:50 +0200
      Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Caleb Crome <caleb@crome.org> - 2015-10-08 04:40 +0200
        Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels  capture and lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-08 04:50 +0200
          Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support Caleb Crome <caleb@crome.org> - 2015-10-08 05:20 +0200
            Re: [alsa-devel] [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels  capture and lrck-mode support sugar <sugar.zhang@rock-chips.com> - 2015-10-08 06:10 +0200

csiph-web