Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1230035 > unrolled thread
| Started by | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| First post | 2015-09-22 12:10 +0200 |
| Last post | 2015-09-23 11:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Sudeep Holla <sudeep.holla@arm.com> - 2015-09-22 12:10 +0200
Re: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Lee Jones <lee.jones@linaro.org> - 2015-09-22 23:10 +0200
Re: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Sudeep Holla <sudeep.holla@arm.com> - 2015-09-23 11:50 +0200
| From | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| Date | 2015-09-22 12:10 +0200 |
| Subject | Re: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND |
| Message-ID | <qbsGm-2d2-37@gated-at.bofh.it> |
On 22/09/15 00:20, Lee Jones wrote: > On Mon, 21 Sep 2015, Sudeep Holla wrote: > >> The IRQF_NO_SUSPEND flag is used to identify the interrupts that should >> be left enabled so as to allow them to work as expected during the >> suspend-resume cycle, but doesn't guarantee that it will wake the system >> from a suspended state, enable_irq_wake is recommended to be used for >> the wakeup. >> >> This patch removes the use of IRQF_NO_SUSPEND flags replacing it with >> enable_irq_wake instead. >> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: linux-arm-kernel@lists.infradead.org >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> --- >> drivers/mfd/ab8500-core.c | 11 +++++++++-- >> drivers/mfd/ab8500-debugfs.c | 2 +- >> drivers/mfd/ab8500-gpadc.c | 15 +++++++++++---- >> drivers/mfd/db8500-prcmu.c | 24 +++++++++++++++++------- >> drivers/power/ab8500_btemp.c | 6 ++++-- >> drivers/power/ab8500_charger.c | 6 ++++-- >> drivers/power/ab8500_fg.c | 9 ++++++--- >> drivers/thermal/db8500_thermal.c | 5 ++--- >> drivers/usb/phy/phy-ab8500-usb.c | 10 ++++++---- >> 9 files changed, 60 insertions(+), 28 deletions(-) > > Is there a reason for bundling the changes in all of these subsystems > together into a single patch? > No, I understand this needs to be split. Since I was not 100% confident about this change, I wanted LinusW to review and provide feedback and gets things working before I can split this changes. I must have added RFC, but usually it gets ignored :) Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-09-22 23:10 +0200 |
| Message-ID | <qbCZ3-af-15@gated-at.bofh.it> |
| In reply to | #1230035 |
On Tue, 22 Sep 2015, Sudeep Holla wrote: > On 22/09/15 00:20, Lee Jones wrote: > >On Mon, 21 Sep 2015, Sudeep Holla wrote: > > > >>The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > >>be left enabled so as to allow them to work as expected during the > >>suspend-resume cycle, but doesn't guarantee that it will wake the system > >>from a suspended state, enable_irq_wake is recommended to be used for > >>the wakeup. > >> > >>This patch removes the use of IRQF_NO_SUSPEND flags replacing it with > >>enable_irq_wake instead. > >> > >>Cc: Linus Walleij <linus.walleij@linaro.org> > >>Cc: linux-arm-kernel@lists.infradead.org > >>Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > >>--- > >> drivers/mfd/ab8500-core.c | 11 +++++++++-- > >> drivers/mfd/ab8500-debugfs.c | 2 +- > >> drivers/mfd/ab8500-gpadc.c | 15 +++++++++++---- > >> drivers/mfd/db8500-prcmu.c | 24 +++++++++++++++++------- > >> drivers/power/ab8500_btemp.c | 6 ++++-- > >> drivers/power/ab8500_charger.c | 6 ++++-- > >> drivers/power/ab8500_fg.c | 9 ++++++--- > >> drivers/thermal/db8500_thermal.c | 5 ++--- > >> drivers/usb/phy/phy-ab8500-usb.c | 10 ++++++---- > >> 9 files changed, 60 insertions(+), 28 deletions(-) > > > >Is there a reason for bundling the changes in all of these subsystems > >together into a single patch? > > > > No, I understand this needs to be split. Since I was not 100% confident > about this change, I wanted LinusW to review and provide feedback and > gets things working before I can split this changes. I must have added > RFC, but usually it gets ignored :) Best if Linus reviews the correct patch-set. Please split and resubmit. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| Date | 2015-09-23 11:50 +0200 |
| Message-ID | <qbOQx-mP-7@gated-at.bofh.it> |
| In reply to | #1230955 |
On 22/09/15 22:03, Lee Jones wrote: > On Tue, 22 Sep 2015, Sudeep Holla wrote: >> On 22/09/15 00:20, Lee Jones wrote: >>> On Mon, 21 Sep 2015, Sudeep Holla wrote: >>> >>>> The IRQF_NO_SUSPEND flag is used to identify the interrupts that should >>>> be left enabled so as to allow them to work as expected during the >>>> suspend-resume cycle, but doesn't guarantee that it will wake the system >>> >from a suspended state, enable_irq_wake is recommended to be used for >>>> the wakeup. >>>> >>>> This patch removes the use of IRQF_NO_SUSPEND flags replacing it with >>>> enable_irq_wake instead. >>>> >>>> Cc: Linus Walleij <linus.walleij@linaro.org> >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >>>> --- >>>> drivers/mfd/ab8500-core.c | 11 +++++++++-- >>>> drivers/mfd/ab8500-debugfs.c | 2 +- >>>> drivers/mfd/ab8500-gpadc.c | 15 +++++++++++---- >>>> drivers/mfd/db8500-prcmu.c | 24 +++++++++++++++++------- >>>> drivers/power/ab8500_btemp.c | 6 ++++-- >>>> drivers/power/ab8500_charger.c | 6 ++++-- >>>> drivers/power/ab8500_fg.c | 9 ++++++--- >>>> drivers/thermal/db8500_thermal.c | 5 ++--- >>>> drivers/usb/phy/phy-ab8500-usb.c | 10 ++++++---- >>>> 9 files changed, 60 insertions(+), 28 deletions(-) >>> >>> Is there a reason for bundling the changes in all of these subsystems >>> together into a single patch? >>> >> >> No, I understand this needs to be split. Since I was not 100% confident >> about this change, I wanted LinusW to review and provide feedback and >> gets things working before I can split this changes. I must have added >> RFC, but usually it gets ignored :) > > Best if Linus reviews the correct patch-set. Please split and > resubmit. > Sure, but would like to get some feedback before I proceed just to ensure my understanding is correct. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web