Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1230035
| From | Sudeep Holla <sudeep.holla@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND |
| Date | 2015-09-22 12:10 +0200 |
| Message-ID | <qbsGm-2d2-37@gated-at.bofh.it> (permalink) |
| References | <qbbvQ-2wt-3@gated-at.bofh.it> <qbbvR-2wt-41@gated-at.bofh.it> <qbiH0-4zP-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 22/09/15 00:20, Lee Jones wrote: > On Mon, 21 Sep 2015, Sudeep Holla wrote: > >> The IRQF_NO_SUSPEND flag is used to identify the interrupts that should >> be left enabled so as to allow them to work as expected during the >> suspend-resume cycle, but doesn't guarantee that it will wake the system >> from a suspended state, enable_irq_wake is recommended to be used for >> the wakeup. >> >> This patch removes the use of IRQF_NO_SUSPEND flags replacing it with >> enable_irq_wake instead. >> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: linux-arm-kernel@lists.infradead.org >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> --- >> drivers/mfd/ab8500-core.c | 11 +++++++++-- >> drivers/mfd/ab8500-debugfs.c | 2 +- >> drivers/mfd/ab8500-gpadc.c | 15 +++++++++++---- >> drivers/mfd/db8500-prcmu.c | 24 +++++++++++++++++------- >> drivers/power/ab8500_btemp.c | 6 ++++-- >> drivers/power/ab8500_charger.c | 6 ++++-- >> drivers/power/ab8500_fg.c | 9 ++++++--- >> drivers/thermal/db8500_thermal.c | 5 ++--- >> drivers/usb/phy/phy-ab8500-usb.c | 10 ++++++---- >> 9 files changed, 60 insertions(+), 28 deletions(-) > > Is there a reason for bundling the changes in all of these subsystems > together into a single patch? > No, I understand this needs to be split. Since I was not 100% confident about this change, I wanted LinusW to review and provide feedback and gets things working before I can split this changes. I must have added RFC, but usually it gets ignored :) Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Sudeep Holla <sudeep.holla@arm.com> - 2015-09-21 17:50 +0200
Re: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Lee Jones <lee.jones@linaro.org> - 2015-09-22 01:30 +0200
Re: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Sudeep Holla <sudeep.holla@arm.com> - 2015-09-22 12:10 +0200
Re: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Lee Jones <lee.jones@linaro.org> - 2015-09-22 23:10 +0200
Re: [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Sudeep Holla <sudeep.holla@arm.com> - 2015-09-23 11:50 +0200
csiph-web