Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318965

Re: [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus

Show all headers | View raw

Hi Kefeng,

2016-01-27 13:27 GMT+09:00 Kefeng Wang <wangkefeng.wang@huawei.com>:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/bus/uniphier-system-bus.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/bus/uniphier-system-bus.c b/drivers/bus/uniphier-system-bus.c
> index 834a2ae..f50bd6d 100644
> --- a/drivers/bus/uniphier-system-bus.c
> +++ b/drivers/bus/uniphier-system-bus.c
> @@ -257,8 +257,7 @@ static int uniphier_system_bus_probe(struct platform_device *pdev)
>         uniphier_system_bus_set_reg(priv);
>
>         /* Now, the bus is configured.  Populate platform_devices below it */
> -       return of_platform_populate(dev->of_node, of_default_bus_match_table,
> -                                   NULL, dev);
> +       return of_platform_default_populate(dev->of_node, NULL, dev);
>  }
>
>  static const struct of_device_id uniphier_system_bus_match[] = {


I did not notice the existence of of_platform_default_populate().

If I had used this function, commit b80443cc22 would have not been
needed in the first place...

Thanks for cleaning this!

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>


-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/15] use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 03/15] mips: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 01/15] arm: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    Re: [PATCH 01/15] arm: use of_platform_default_populate() to  populate default bus kbuild test robot <lkp@intel.com> - 2016-01-27 08:10 +0100
      Re: [PATCH 01/15] arm: use of_platform_default_populate() to populate  default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 09:00 +0100
    [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 09:00 +0100
  [PATCH 12/15] memory: omap-gpmc: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 08/15] nios2: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 13/15] of: unittest: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 05/15] c6x: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 02/15] arm64: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    Re: [PATCH 02/15] arm64: use of_platform_default_populate() to  populate default bus Catalin Marinas <catalin.marinas@arm.com> - 2016-01-27 11:40 +0100
  [PATCH 04/15] arc: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    Re: [PATCH 04/15] arc: use of_platform_default_populate() to  populate default bus Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-01-27 09:00 +0100
  [PATCH 06/15] metag: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    Re: [PATCH 06/15] metag: use of_platform_default_populate() to  populate default bus James Hogan <james.hogan@imgtec.com> - 2016-01-27 12:40 +0100
  Re: [PATCH 09/15] xtensa: use of_platform_default_populate() to  populate default bus Max Filippov <jcmvbkbc@gmail.com> - 2016-01-27 05:40 +0100
  [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
    Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-27 14:50 +0100
  [PATCH 07/15] cris: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
  [PATCH 09/15] xtensa: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
  [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
    Re: [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate()  to populate default bus Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-27 14:50 +0100

csiph-web