Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320077 > unrolled thread
| Started by | Eric Curtin <ericcurtin17@gmail.com> |
|---|---|
| First post | 2016-01-27 23:20 +0100 |
| Last post | 2016-02-07 21:20 +0100 |
| Articles | 9 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-27 23:20 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Joe Perches <joe@perches.com> - 2016-01-28 00:30 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-28 01:40 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Joe Perches <joe@perches.com> - 2016-01-28 01:50 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-28 02:00 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-30 13:30 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-30 18:00 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-30 21:00 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Darren Hart <dvhart@infradead.org> - 2016-02-07 21:20 +0100
| From | Eric Curtin <ericcurtin17@gmail.com> |
|---|---|
| Date | 2016-01-27 23:20 +0100 |
| Subject | [PATCH] Remove ambiguous logging for "Unsupported brightness interface" |
| Message-ID | <qVGBt-20k-41@gated-at.bofh.it> |
Message gets logged on machines that are well supported.
Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
---
drivers/platform/x86/thinkpad_acpi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index a268a7a..4eb41aa 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6661,7 +6661,6 @@ static void __init
tpacpi_detect_brightness_capabilities(void)
pr_info("detected a 8-level brightness capable ThinkPad\n");
break;
default:
- pr_info("Unsupported brightness interface\n");
tp_features.bright_unkfw = 1;
bright_maxlvl = b - 1;
}
--
2.5.0
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-01-28 00:30 +0100 |
| Subject | Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" |
| Message-ID | <qVHHc-2KP-19@gated-at.bofh.it> |
| In reply to | #1320077 |
On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
> Message gets logged on machines that are well supported.
>
> Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index a268a7a..4eb41aa 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6661,7 +6661,6 @@ static void __init
> tpacpi_detect_brightness_capabilities(void)
> pr_info("detected a 8-level brightness capable
> ThinkPad\n");
> break;
> default:
> - pr_info("Unsupported brightness interface\n");
> tp_features.bright_unkfw = 1;
> bright_maxlvl = b - 1;
> }
Perhaps this should be something like this instead:
---
drivers/platform/x86/thinkpad_acpi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index a268a7a..bd12c71 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)
switch (b) {
case 16:
bright_maxlvl = 15;
- pr_info("detected a 16-level brightness capable ThinkPad\n");
break;
case 8:
case 0:
bright_maxlvl = 7;
- pr_info("detected a 8-level brightness capable ThinkPad\n");
break;
default:
- pr_info("Unsupported brightness interface\n");
tp_features.bright_unkfw = 1;
bright_maxlvl = b - 1;
}
+ pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
}
static int __init brightness_init(struct ibm_init_struct *iibm)
[toc] | [prev] | [next] | [standalone]
| From | Eric Curtin <ericcurtin17@gmail.com> |
|---|---|
| Date | 2016-01-28 01:40 +0100 |
| Message-ID | <qVIMW-3vP-17@gated-at.bofh.it> |
| In reply to | #1320137 |
On 27 January 2016 at 23:26, Joe Perches <joe@perches.com> wrote:
> On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
>> Message gets logged on machines that are well supported.
>>
>> Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
>> ---
>> drivers/platform/x86/thinkpad_acpi.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/thinkpad_acpi.c
>> b/drivers/platform/x86/thinkpad_acpi.c
>> index a268a7a..4eb41aa 100644
>> --- a/drivers/platform/x86/thinkpad_acpi.c
>> +++ b/drivers/platform/x86/thinkpad_acpi.c
>> @@ -6661,7 +6661,6 @@ static void __init
>> tpacpi_detect_brightness_capabilities(void)
>> pr_info("detected a 8-level brightness capable
>> ThinkPad\n");
>> break;
>> default:
>> - pr_info("Unsupported brightness interface\n");
>> tp_features.bright_unkfw = 1;
>> bright_maxlvl = b - 1;
>> }
>
> Perhaps this should be something like this instead:
> ---
> drivers/platform/x86/thinkpad_acpi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index a268a7a..bd12c71 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)
> switch (b) {
> case 16:
> bright_maxlvl = 15;
> - pr_info("detected a 16-level brightness capable ThinkPad\n");
> break;
> case 8:
> case 0:
> bright_maxlvl = 7;
> - pr_info("detected a 8-level brightness capable ThinkPad\n");
> break;
> default:
> - pr_info("Unsupported brightness interface\n");
> tp_features.bright_unkfw = 1;
> bright_maxlvl = b - 1;
> }
> + pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
> }
>
> static int __init brightness_init(struct ibm_init_struct *iibm)
Maybe, but the other logging issues kinda mean something. There are
many, many reports of people thinking their brightness interface is
broken because of this logging message, when in reality the i915 driver
supports their devices just fine as previously stated.
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-01-28 01:50 +0100 |
| Subject | Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" |
| Message-ID | <qVIWC-3zl-13@gated-at.bofh.it> |
| In reply to | #1320173 |
On Thu, 2016-01-28 at 00:36 +0000, Eric Curtin wrote:
> On 27 January 2016 at 23:26, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
> > > Message gets logged on machines that are well supported.
[]
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
[]
> > + pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
> > }
> >
> > static int __init brightness_init(struct ibm_init_struct *iibm)
>
> Maybe, but the other logging issues kinda mean something. There are
> many, many reports of people thinking their brightness interface is
> broken because of this logging message, when in reality the i915 driver
> supports their devices just fine as previously stated.
That's why I suggest changing it to show the number
of brightness levels detected on any device.
[toc] | [prev] | [next] | [standalone]
| From | Eric Curtin <ericcurtin17@gmail.com> |
|---|---|
| Date | 2016-01-28 02:00 +0100 |
| Message-ID | <qVJ6i-3DX-9@gated-at.bofh.it> |
| In reply to | #1320182 |
On 28 January 2016 at 00:43, Joe Perches <joe@perches.com> wrote:
> On Thu, 2016-01-28 at 00:36 +0000, Eric Curtin wrote:
>> On 27 January 2016 at 23:26, Joe Perches <joe@perches.com> wrote:
>> > On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
>> > > Message gets logged on machines that are well supported.
> []
>> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> []
>> > + pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
>> > }
>> >
>> > static int __init brightness_init(struct ibm_init_struct *iibm)
>>
>> Maybe, but the other logging issues kinda mean something. There are
>> many, many reports of people thinking their brightness interface is
>> broken because of this logging message, when in reality the i915 driver
>> supports their devices just fine as previously stated.
>
> That's why I suggest changing it to show the number
> of brightness levels detected on any device.
>
Sorry, I missed that line. Looks like a better fix! +1
[toc] | [prev] | [next] | [standalone]
| From | Henrique de Moraes Holschuh <hmh@hmh.eng.br> |
|---|---|
| Date | 2016-01-30 13:30 +0100 |
| Subject | Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" |
| Message-ID | <qWCP8-2Cc-5@gated-at.bofh.it> |
| In reply to | #1320137 |
On Wed, 27 Jan 2016, Joe Perches wrote:
> On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
> > Message gets logged on machines that are well supported.
> >
> > Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> > ---
> > drivers/platform/x86/thinkpad_acpi.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c
> > b/drivers/platform/x86/thinkpad_acpi.c
> > index a268a7a..4eb41aa 100644
> > --- a/drivers/platform/x86/thinkpad_acpi.c
> > +++ b/drivers/platform/x86/thinkpad_acpi.c
> > @@ -6661,7 +6661,6 @@ static void __init
> > tpacpi_detect_brightness_capabilities(void)
> > pr_info("detected a 8-level brightness capable
> > ThinkPad\n");
> > break;
> > default:
> > - pr_info("Unsupported brightness interface\n");
> > tp_features.bright_unkfw = 1;
> > bright_maxlvl = b - 1;
> > }
>
> Perhaps this should be something like this instead:
> ---
> drivers/platform/x86/thinkpad_acpi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index a268a7a..bd12c71 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)
> switch (b) {
> case 16:
> bright_maxlvl = 15;
> - pr_info("detected a 16-level brightness capable ThinkPad\n");
> break;
> case 8:
> case 0:
> bright_maxlvl = 7;
> - pr_info("detected a 8-level brightness capable ThinkPad\n");
> break;
> default:
> - pr_info("Unsupported brightness interface\n");
> tp_features.bright_unkfw = 1;
> bright_maxlvl = b - 1;
> }
> + pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
> }
This can be made pr_debug, since we're touching it...
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
[toc] | [prev] | [next] | [standalone]
| From | Eric Curtin <ericcurtin17@gmail.com> |
|---|---|
| Date | 2016-01-30 18:00 +0100 |
| Message-ID | <qWH2r-6AY-35@gated-at.bofh.it> |
| In reply to | #1322347 |
On 30 January 2016 at 12:20, Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote:
> On Wed, 27 Jan 2016, Joe Perches wrote:
>> On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
>> > Message gets logged on machines that are well supported.
>> >
>> > Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
>> > ---
>> > drivers/platform/x86/thinkpad_acpi.c | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> > diff --git a/drivers/platform/x86/thinkpad_acpi.c
>> > b/drivers/platform/x86/thinkpad_acpi.c
>> > index a268a7a..4eb41aa 100644
>> > --- a/drivers/platform/x86/thinkpad_acpi.c
>> > +++ b/drivers/platform/x86/thinkpad_acpi.c
>> > @@ -6661,7 +6661,6 @@ static void __init
>> > tpacpi_detect_brightness_capabilities(void)
>> > pr_info("detected a 8-level brightness capable
>> > ThinkPad\n");
>> > break;
>> > default:
>> > - pr_info("Unsupported brightness interface\n");
>> > tp_features.bright_unkfw = 1;
>> > bright_maxlvl = b - 1;
>> > }
>>
>> Perhaps this should be something like this instead:
>> ---
>> drivers/platform/x86/thinkpad_acpi.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
>> index a268a7a..bd12c71 100644
>> --- a/drivers/platform/x86/thinkpad_acpi.c
>> +++ b/drivers/platform/x86/thinkpad_acpi.c
>> @@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)
>> switch (b) {
>> case 16:
>> bright_maxlvl = 15;
>> - pr_info("detected a 16-level brightness capable ThinkPad\n");
>> break;
>> case 8:
>> case 0:
>> bright_maxlvl = 7;
>> - pr_info("detected a 8-level brightness capable ThinkPad\n");
>> break;
>> default:
>> - pr_info("Unsupported brightness interface\n");
>> tp_features.bright_unkfw = 1;
>> bright_maxlvl = b - 1;
>> }
>> + pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
>> }
>
> This can be made pr_debug, since we're touching it...
>
> --
> "One disk to rule them all, One disk to find them. One disk to bring
> them all and in the darkness grind them. In the Land of Redmond
> where the shadows lie." -- The Silicon Valley Tarot
> Henrique Holschuh
"Unsupported brightness interface" message gets logged on
machines that are well supported.
Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
---
drivers/platform/x86/thinkpad_acpi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index a268a7a..e305ab5 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6653,18 +6653,16 @@ static void __init
tpacpi_detect_brightness_capabilities(void)
switch (b) {
case 16:
bright_maxlvl = 15;
- pr_info("detected a 16-level brightness capable ThinkPad\n");
break;
case 8:
case 0:
bright_maxlvl = 7;
- pr_info("detected a 8-level brightness capable ThinkPad\n");
break;
default:
- pr_info("Unsupported brightness interface\n");
tp_features.bright_unkfw = 1;
bright_maxlvl = b - 1;
}
+ pr_debug("detected %u brightness levels\n", bright_maxlvl + 1);
}
static int __init brightness_init(struct ibm_init_struct *iibm)
--
2.5.0
[toc] | [prev] | [next] | [standalone]
| From | Henrique de Moraes Holschuh <hmh@hmh.eng.br> |
|---|---|
| Date | 2016-01-30 21:00 +0100 |
| Subject | Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" |
| Message-ID | <qWJQC-gY-7@gated-at.bofh.it> |
| In reply to | #1322422 |
On Sat, 30 Jan 2016, Eric Curtin wrote:
> "Unsupported brightness interface" message gets logged on
> machines that are well supported.
>
> Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index a268a7a..e305ab5 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6653,18 +6653,16 @@ static void __init
> tpacpi_detect_brightness_capabilities(void)
> switch (b) {
> case 16:
> bright_maxlvl = 15;
> - pr_info("detected a 16-level brightness capable ThinkPad\n");
> break;
> case 8:
> case 0:
> bright_maxlvl = 7;
> - pr_info("detected a 8-level brightness capable ThinkPad\n");
> break;
> default:
> - pr_info("Unsupported brightness interface\n");
> tp_features.bright_unkfw = 1;
> bright_maxlvl = b - 1;
> }
> + pr_debug("detected %u brightness levels\n", bright_maxlvl + 1);
> }
>
> static int __init brightness_init(struct ibm_init_struct *iibm)
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
[toc] | [prev] | [next] | [standalone]
| From | Darren Hart <dvhart@infradead.org> |
|---|---|
| Date | 2016-02-07 21:20 +0100 |
| Subject | Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" |
| Message-ID | <qZDYl-2R5-3@gated-at.bofh.it> |
| In reply to | #1322422 |
On Sat, Jan 30, 2016 at 04:55:59PM +0000, Eric Curtin wrote:
> On 30 January 2016 at 12:20, Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote:
> > On Wed, 27 Jan 2016, Joe Perches wrote:
> >> On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
> >> > Message gets logged on machines that are well supported.
> >> >
> >> > Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> >> > ---
> >> > drivers/platform/x86/thinkpad_acpi.c | 1 -
> >> > 1 file changed, 1 deletion(-)
> >> >
> >> > diff --git a/drivers/platform/x86/thinkpad_acpi.c
> >> > b/drivers/platform/x86/thinkpad_acpi.c
> >> > index a268a7a..4eb41aa 100644
> >> > --- a/drivers/platform/x86/thinkpad_acpi.c
> >> > +++ b/drivers/platform/x86/thinkpad_acpi.c
> >> > @@ -6661,7 +6661,6 @@ static void __init
> >> > tpacpi_detect_brightness_capabilities(void)
> >> > pr_info("detected a 8-level brightness capable
> >> > ThinkPad\n");
> >> > break;
> >> > default:
> >> > - pr_info("Unsupported brightness interface\n");
> >> > tp_features.bright_unkfw = 1;
> >> > bright_maxlvl = b - 1;
> >> > }
> >>
> >> Perhaps this should be something like this instead:
> >> ---
> >> drivers/platform/x86/thinkpad_acpi.c | 4 +---
> >> 1 file changed, 1 insertion(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> >> index a268a7a..bd12c71 100644
> >> --- a/drivers/platform/x86/thinkpad_acpi.c
> >> +++ b/drivers/platform/x86/thinkpad_acpi.c
> >> @@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)
> >> switch (b) {
> >> case 16:
> >> bright_maxlvl = 15;
> >> - pr_info("detected a 16-level brightness capable ThinkPad\n");
> >> break;
> >> case 8:
> >> case 0:
> >> bright_maxlvl = 7;
> >> - pr_info("detected a 8-level brightness capable ThinkPad\n");
> >> break;
> >> default:
> >> - pr_info("Unsupported brightness interface\n");
> >> tp_features.bright_unkfw = 1;
> >> bright_maxlvl = b - 1;
> >> }
> >> + pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
> >> }
> >
> > This can be made pr_debug, since we're touching it...
> >
> > --
> > "One disk to rule them all, One disk to find them. One disk to bring
> > them all and in the darkness grind them. In the Land of Redmond
> > where the shadows lie." -- The Silicon Valley Tarot
> > Henrique Holschuh
>
> "Unsupported brightness interface" message gets logged on
> machines that are well supported.
>
> Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index a268a7a..e305ab5 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6653,18 +6653,16 @@ static void __init
> tpacpi_detect_brightness_capabilities(void)
> switch (b) {
> case 16:
> bright_maxlvl = 15;
> - pr_info("detected a 16-level brightness capable ThinkPad\n");
> break;
> case 8:
> case 0:
> bright_maxlvl = 7;
> - pr_info("detected a 8-level brightness capable ThinkPad\n");
> break;
> default:
> - pr_info("Unsupported brightness interface\n");
> tp_features.bright_unkfw = 1;
> bright_maxlvl = b - 1;
> }
> + pr_debug("detected %u brightness levels\n", bright_maxlvl + 1);
This patch is malformed, has whitespace issues, and doesn't apply. Please apply
all patches before sending them to the list.
Given it's trivial, I made the change manually and have queued this up to the
testing branch.
Thanks,
--
Darren Hart
Intel Open Source Technology Center
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web