Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320182

Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface"

Show all headers | View raw

On Thu, 2016-01-28 at 00:36 +0000, Eric Curtin wrote:
> On 27 January 2016 at 23:26, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
> > > Message gets logged on machines that are well supported.
[]
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
[]
> > +       pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
> >  }
> > 
> >  static int __init brightness_init(struct ibm_init_struct *iibm)
> 
> Maybe, but the other logging issues kinda mean something. There are
> many, many reports of people thinking their brightness interface is
> broken because of this logging message, when in reality the i915 driver
> supports their devices just fine as previously stated.

That's why I suggest changing it to show the number
of brightness levels detected on any device.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-27 23:20 +0100
  Re: [PATCH] Remove ambiguous logging for "Unsupported brightness  interface" Joe Perches <joe@perches.com> - 2016-01-28 00:30 +0100
    Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-28 01:40 +0100
      Re: [PATCH] Remove ambiguous logging for "Unsupported brightness  interface" Joe Perches <joe@perches.com> - 2016-01-28 01:50 +0100
        Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-28 02:00 +0100
    Re: [PATCH] Remove ambiguous logging for "Unsupported brightness  interface" Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-30 13:30 +0100
      Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-30 18:00 +0100
        Re: [PATCH] Remove ambiguous logging for "Unsupported brightness  interface" Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-30 21:00 +0100
        Re: [PATCH] Remove ambiguous logging for "Unsupported brightness  interface" Darren Hart <dvhart@infradead.org> - 2016-02-07 21:20 +0100

csiph-web