Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320137
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" |
| Date | 2016-01-28 00:30 +0100 |
| Message-ID | <qVHHc-2KP-19@gated-at.bofh.it> (permalink) |
| References | <qVGBt-20k-41@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
> Message gets logged on machines that are well supported.
>
> Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index a268a7a..4eb41aa 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6661,7 +6661,6 @@ static void __init
> tpacpi_detect_brightness_capabilities(void)
> pr_info("detected a 8-level brightness capable
> ThinkPad\n");
> break;
> default:
> - pr_info("Unsupported brightness interface\n");
> tp_features.bright_unkfw = 1;
> bright_maxlvl = b - 1;
> }
Perhaps this should be something like this instead:
---
drivers/platform/x86/thinkpad_acpi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index a268a7a..bd12c71 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)
switch (b) {
case 16:
bright_maxlvl = 15;
- pr_info("detected a 16-level brightness capable ThinkPad\n");
break;
case 8:
case 0:
bright_maxlvl = 7;
- pr_info("detected a 8-level brightness capable ThinkPad\n");
break;
default:
- pr_info("Unsupported brightness interface\n");
tp_features.bright_unkfw = 1;
bright_maxlvl = b - 1;
}
+ pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
}
static int __init brightness_init(struct ibm_init_struct *iibm)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-27 23:20 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Joe Perches <joe@perches.com> - 2016-01-28 00:30 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-28 01:40 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Joe Perches <joe@perches.com> - 2016-01-28 01:50 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-28 02:00 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-30 13:30 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Eric Curtin <ericcurtin17@gmail.com> - 2016-01-30 18:00 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-30 21:00 +0100
Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Darren Hart <dvhart@infradead.org> - 2016-02-07 21:20 +0100
csiph-web