Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1304135 > unrolled thread
| Started by | Jiancheng Xue <xuejiancheng@huawei.com> |
|---|---|
| First post | 2016-01-08 03:30 +0100 |
| Last post | 2016-01-11 03:10 +0100 |
| Articles | 20 on this page of 21 — 6 participants |
Back to article view | Back to linux.kernel
[PATCH v5 0/6] ARM: hisi: Add initial support including clock driver for Hi3519 soc. Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:30 +0100
[PATCH v5 4/6] ARM: debug: add hi3519 debug uart Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
Re: [PATCH v5 4/6] ARM: debug: add hi3519 debug uart Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-08 16:10 +0100
Re: [PATCH v5 4/6] ARM: debug: add hi3519 debug uart xuejiancheng <xuejiancheng@huawei.com> - 2016-01-11 03:50 +0100
[PATCH v5 3/6] ARM: config: hisi: enable CONFIG_RESET_CONTROLLER Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
[PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Rob Herring <robh@kernel.org> - 2016-01-08 22:10 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-11 06:50 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-11 09:00 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-11 10:00 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-12 02:40 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-12 08:50 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-12 09:30 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-12 09:50 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-12 10:40 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Arnd Bergmann <arnd@arndb.de> - 2016-01-13 00:00 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-13 10:30 +0100
Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Arnd Bergmann <arnd@arndb.de> - 2016-01-13 11:10 +0100
[PATCH v5 6/6] ARM: dts: add dts files for Hi3519 Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-08 16:20 +0100
Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 xuejiancheng <xuejiancheng@huawei.com> - 2016-01-11 03:10 +0100
Page 1 of 2 [1] 2 Next page →
| From | Jiancheng Xue <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-08 03:30 +0100 |
| Subject | [PATCH v5 0/6] ARM: hisi: Add initial support including clock driver for Hi3519 soc. |
| Message-ID | <qOuYq-8uq-9@gated-at.bofh.it> |
Hello, Hi3519 soc is mainly used for ip camera and sport DV solutions. This patchset adds initial support for Hi3519 soc. It includes clock driver, arch configuration, debug uart configuration and device tree. It has been tested on hi3519 reference board. Any comments will be appreciated! Thanks! Change Log ---------- v5: -Adjust clock and reset controller driver code v4: -Rebase to v4.4-rc7 -Divide patches according to Rob's comments -Add spi nodes in hi3519-demb.dts v3: -Rebase to v4.4-rc4 -Adjust according to Arnd's comments -Remove ARCH_HI3519, using ARCH_HISI directly v2: -Rebase to v4.4-rc3 -Put dt-binding doc and header file in a separate patch. -Delete unused clocks definitions. -Adjust the ARCH_xxx order in Kconfig file -Rename ARCH_HI3xxx to ARCH_36xx Jiancheng Xue (6): clk: hisilicon: add CRG driver for hi3519 soc ARM: hisi: add compatible string for Hi3519 soc ARM: config: hisi: enable CONFIG_RESET_CONTROLLER ARM: debug: add hi3519 debug uart mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl ARM: dts: add dts files for Hi3519 Jiancheng Xue (6): clk: hisilicon: add CRG driver for hi3519 soc ARM: hisi: add compatible string for Hi3519 soc ARM: config: hisi: enable CONFIG_RESET_CONTROLLER ARM: debug: add hi3519 debug uart mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl ARM: dts: add dts files for Hi3519 .../devicetree/bindings/clock/hi3519-crg.txt | 46 ++++++ Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++ arch/arm/Kconfig.debug | 10 ++ arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/hi3519-demb.dts | 42 +++++ arch/arm/boot/dts/hi3519.dtsi | 175 +++++++++++++++++++++ arch/arm/configs/hisi_defconfig | 1 + arch/arm/mach-hisi/hisilicon.c | 23 +-- drivers/clk/hisilicon/Kconfig | 7 + drivers/clk/hisilicon/Makefile | 2 + drivers/clk/hisilicon/clk-hi3519.c | 105 +++++++++++++ drivers/clk/hisilicon/reset.c | 129 +++++++++++++++ drivers/clk/hisilicon/reset.h | 32 ++++ include/dt-bindings/clock/hi3519-clock.h | 43 +++++ 14 files changed, 612 insertions(+), 19 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/hi3519-crg.txt create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt create mode 100644 arch/arm/boot/dts/hi3519-demb.dts create mode 100644 arch/arm/boot/dts/hi3519.dtsi create mode 100644 drivers/clk/hisilicon/clk-hi3519.c create mode 100644 drivers/clk/hisilicon/reset.c create mode 100644 drivers/clk/hisilicon/reset.h create mode 100644 include/dt-bindings/clock/hi3519-clock.h -- 1.9.1
[toc] | [next] | [standalone]
| From | Jiancheng Xue <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-08 03:40 +0100 |
| Subject | [PATCH v5 4/6] ARM: debug: add hi3519 debug uart |
| Message-ID | <qOv85-7I-9@gated-at.bofh.it> |
| In reply to | #1304135 |
add hi3519 debug uart. Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> --- arch/arm/Kconfig.debug | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 259c0ca..29af057 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -270,6 +270,14 @@ choice Say Y here if you want the debug print routines to direct their output to the 8250 at PCI COM1. + config DEBUG_HI3519_UART + bool "Hisilicon Hi3519 Debug UART" + depends on ARCH_HISI + select DEBUG_UART_PL01X + help + Say Y here if you want kernel low-level debugging support + on HI3519 UART. + config DEBUG_HI3620_UART bool "Hisilicon HI3620 Debug UART" depends on ARCH_HI3xxx @@ -1449,6 +1457,7 @@ config DEBUG_UART_PHYS default 0xf7fc9000 if DEBUG_BERLIN_UART default 0xf8b00000 if DEBUG_HIX5HD2_UART default 0xf991e000 if DEBUG_QCOM_UARTDM + default 0x12100000 if DEBUG_HI3519_UART default 0xfcb00000 if DEBUG_HI3620_UART default 0xfd883000 if DEBUG_ALPINE_UART0 default 0xfe800000 if ARCH_IOP32X @@ -1529,6 +1538,7 @@ config DEBUG_UART_VIRT default 0xfe230000 if DEBUG_PICOXCELL_UART default 0xfe300000 if DEBUG_BCM_KONA_UART default 0xfe800000 if ARCH_IOP32X + default 0xfef00000 if DEBUG_HI3519_UART default 0xfeb00000 if DEBUG_HI3620_UART || DEBUG_HIX5HD2_UART default 0xfeb24000 if DEBUG_RK3X_UART0 default 0xfeb26000 if DEBUG_RK3X_UART1 -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Russell King - ARM Linux <linux@arm.linux.org.uk> |
|---|---|
| Date | 2016-01-08 16:10 +0100 |
| Subject | Re: [PATCH v5 4/6] ARM: debug: add hi3519 debug uart |
| Message-ID | <qOGPT-8rM-1@gated-at.bofh.it> |
| In reply to | #1304138 |
On Fri, Jan 08, 2016 at 10:16:38AM +0800, Jiancheng Xue wrote: > @@ -1449,6 +1457,7 @@ config DEBUG_UART_PHYS > default 0xf7fc9000 if DEBUG_BERLIN_UART > default 0xf8b00000 if DEBUG_HIX5HD2_UART > default 0xf991e000 if DEBUG_QCOM_UARTDM > + default 0x12100000 if DEBUG_HI3519_UART > default 0xfcb00000 if DEBUG_HI3620_UART > default 0xfd883000 if DEBUG_ALPINE_UART0 > default 0xfe800000 if ARCH_IOP32X Please insert at the appropriate location - examination of the list of defaults will show that it's sorted numerically, please keep this sorted numerically. > @@ -1529,6 +1538,7 @@ config DEBUG_UART_VIRT > default 0xfe230000 if DEBUG_PICOXCELL_UART > default 0xfe300000 if DEBUG_BCM_KONA_UART > default 0xfe800000 if ARCH_IOP32X > + default 0xfef00000 if DEBUG_HI3519_UART > default 0xfeb00000 if DEBUG_HI3620_UART || DEBUG_HIX5HD2_UART > default 0xfeb24000 if DEBUG_RK3X_UART0 > default 0xfeb26000 if DEBUG_RK3X_UART1 Same for here. Thanks. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
[toc] | [prev] | [next] | [standalone]
| From | xuejiancheng <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-11 03:50 +0100 |
| Subject | Re: [PATCH v5 4/6] ARM: debug: add hi3519 debug uart |
| Message-ID | <qPAIq-4uQ-15@gated-at.bofh.it> |
| In reply to | #1304624 |
Hello Russell, On 2016/1/8 23:08, Russell King - ARM Linux wrote: > On Fri, Jan 08, 2016 at 10:16:38AM +0800, Jiancheng Xue wrote: >> @@ -1449,6 +1457,7 @@ config DEBUG_UART_PHYS >> default 0xf7fc9000 if DEBUG_BERLIN_UART >> default 0xf8b00000 if DEBUG_HIX5HD2_UART >> default 0xf991e000 if DEBUG_QCOM_UARTDM >> + default 0x12100000 if DEBUG_HI3519_UART >> default 0xfcb00000 if DEBUG_HI3620_UART >> default 0xfd883000 if DEBUG_ALPINE_UART0 >> default 0xfe800000 if ARCH_IOP32X > > Please insert at the appropriate location - examination of the list > of defaults will show that it's sorted numerically, please keep this > sorted numerically. > OK. Thank you! >> @@ -1529,6 +1538,7 @@ config DEBUG_UART_VIRT >> default 0xfe230000 if DEBUG_PICOXCELL_UART >> default 0xfe300000 if DEBUG_BCM_KONA_UART >> default 0xfe800000 if ARCH_IOP32X >> + default 0xfef00000 if DEBUG_HI3519_UART >> default 0xfeb00000 if DEBUG_HI3620_UART || DEBUG_HIX5HD2_UART >> default 0xfeb24000 if DEBUG_RK3X_UART0 >> default 0xfeb26000 if DEBUG_RK3X_UART1 > > Same for here. > > Thanks. >
[toc] | [prev] | [next] | [standalone]
| From | Jiancheng Xue <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-08 03:40 +0100 |
| Subject | [PATCH v5 3/6] ARM: config: hisi: enable CONFIG_RESET_CONTROLLER |
| Message-ID | <qOv85-7I-7@gated-at.bofh.it> |
| In reply to | #1304135 |
enable CONFIG_RESET_CONTROLLER in hisi_defconfig Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> --- arch/arm/configs/hisi_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/hisi_defconfig b/arch/arm/configs/hisi_defconfig index b2e340b..ba62c07 100644 --- a/arch/arm/configs/hisi_defconfig +++ b/arch/arm/configs/hisi_defconfig @@ -75,6 +75,7 @@ CONFIG_DMADEVICES=y CONFIG_DW_DMAC=y CONFIG_PL330_DMA=y CONFIG_PWM=y +CONFIG_RESET_CONTROLLER=y CONFIG_PHY_HIX5HD2_SATA=y CONFIG_EXT4_FS=y CONFIG_TMPFS=y -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Jiancheng Xue <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-08 03:40 +0100 |
| Subject | [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qOv85-7I-11@gated-at.bofh.it> |
| In reply to | #1304135 |
Add device tree bindings for Hi3519 system controller.
Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
---
Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
1 file changed, 14 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
new file mode 100644
index 0000000..115c5be
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
@@ -0,0 +1,14 @@
+* Hisilicon Hi3519 System Controller Block
+
+This bindings use the following binding:
+Documentation/devicetree/bindings/mfd/syscon.txt
+
+Required properties:
+- compatible: "hisilicon,hi3519-sysctrl".
+- reg: the register region of this block
+
+Examples:
+sysctrl: system-controller@12010000 {
+ compatible = "hisilicon,hi3519-sysctrl", "syscon";
+ reg = <0x12010000 0x1000>;
+};
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-01-08 22:10 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qOMsh-3Yx-5@gated-at.bofh.it> |
| In reply to | #1304140 |
On Fri, Jan 08, 2016 at 10:16:39AM +0800, Jiancheng Xue wrote: > Add device tree bindings for Hi3519 system controller. > > Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> > --- > Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt This seems like it could be combined with other HiSi system controller bindings if the compatible string is the only difference. But it is fine like this: Acked-by: Rob Herring <robh@kernel.org> Rob
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-01-11 06:50 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qPDwD-6rd-23@gated-at.bofh.it> |
| In reply to | #1304140 |
On Fri, 08 Jan 2016, Jiancheng Xue wrote:
> Add device tree bindings for Hi3519 system controller.
>
> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
> ---
> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
I have this patch, but none of the others in the set, thus I am
lacking context.
> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
> new file mode 100644
> index 0000000..115c5be
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
> @@ -0,0 +1,14 @@
> +* Hisilicon Hi3519 System Controller Block
> +
> +This bindings use the following binding:
> +Documentation/devicetree/bindings/mfd/syscon.txt
> +
> +Required properties:
> +- compatible: "hisilicon,hi3519-sysctrl".
> +- reg: the register region of this block
> +
> +Examples:
> +sysctrl: system-controller@12010000 {
> + compatible = "hisilicon,hi3519-sysctrl", "syscon";
> + reg = <0x12010000 0x1000>;
> +};
There is no requirement (nor want) for binding documents where the
given device is simply using highly generic bindings. This just
amounts to churn.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | xuejiancheng <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-11 09:00 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qPFyq-7Lg-25@gated-at.bofh.it> |
| In reply to | #1305859 |
Hi Lee Jones,
Thanks for your comments.
On 2016/1/11 13:48, Lee Jones wrote:
> On Fri, 08 Jan 2016, Jiancheng Xue wrote:
>
>> Add device tree bindings for Hi3519 system controller.
>>
>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
>> ---
>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
>
> I have this patch, but none of the others in the set, thus I am
> lacking context.
>
I can forward other patches in the set to you. Thank you.
>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
>> new file mode 100644
>> index 0000000..115c5be
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
>> @@ -0,0 +1,14 @@
>> +* Hisilicon Hi3519 System Controller Block
>> +
>> +This bindings use the following binding:
>> +Documentation/devicetree/bindings/mfd/syscon.txt
>> +
>> +Required properties:
>> +- compatible: "hisilicon,hi3519-sysctrl".
>> +- reg: the register region of this block
>> +
>> +Examples:
>> +sysctrl: system-controller@12010000 {
>> + compatible = "hisilicon,hi3519-sysctrl", "syscon";
>> + reg = <0x12010000 0x1000>;
>> +};
>
> There is no requirement (nor want) for binding documents where the
> given device is simply using highly generic bindings. This just
> amounts to churn.
>
This block is specific for Hi3519 SOC, and may has its own driver.
So I think it's better to keep this binding.
Jiancheng
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-01-11 10:00 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qPGuu-8mW-17@gated-at.bofh.it> |
| In reply to | #1305927 |
On Mon, 11 Jan 2016, xuejiancheng wrote:
> On 2016/1/11 13:48, Lee Jones wrote:
> > On Fri, 08 Jan 2016, Jiancheng Xue wrote:
> >
> >> Add device tree bindings for Hi3519 system controller.
> >>
> >> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
> >> ---
> >> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
> >> 1 file changed, 14 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
> >
> > I have this patch, but none of the others in the set, thus I am
> > lacking context.
> >
> I can forward other patches in the set to you. Thank you.
>
> >> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
> >> new file mode 100644
> >> index 0000000..115c5be
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
> >> @@ -0,0 +1,14 @@
> >> +* Hisilicon Hi3519 System Controller Block
> >> +
> >> +This bindings use the following binding:
> >> +Documentation/devicetree/bindings/mfd/syscon.txt
> >> +
> >> +Required properties:
> >> +- compatible: "hisilicon,hi3519-sysctrl".
> >> +- reg: the register region of this block
> >> +
> >> +Examples:
> >> +sysctrl: system-controller@12010000 {
> >> + compatible = "hisilicon,hi3519-sysctrl", "syscon";
> >> + reg = <0x12010000 0x1000>;
> >> +};
> >
> > There is no requirement (nor want) for binding documents where the
> > given device is simply using highly generic bindings. This just
> > amounts to churn.
> >
> This block is specific for Hi3519 SOC, and may has its own driver.
Does it have its own driver currently?
> So I think it's better to keep this binding.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | xuejiancheng <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-12 02:40 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qPW6f-2l7-31@gated-at.bofh.it> |
| In reply to | #1305961 |
On 2016/1/11 16:55, Lee Jones wrote:
> On Mon, 11 Jan 2016, xuejiancheng wrote:
>> On 2016/1/11 13:48, Lee Jones wrote:
>>> On Fri, 08 Jan 2016, Jiancheng Xue wrote:
>>>
>>>> Add device tree bindings for Hi3519 system controller.
>>>>
>>>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
>>>> ---
>>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
>>>> 1 file changed, 14 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
>>>
>>> I have this patch, but none of the others in the set, thus I am
>>> lacking context.
>>>
>> I can forward other patches in the set to you. Thank you.
>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
>>>> new file mode 100644
>>>> index 0000000..115c5be
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
>>>> @@ -0,0 +1,14 @@
>>>> +* Hisilicon Hi3519 System Controller Block
>>>> +
>>>> +This bindings use the following binding:
>>>> +Documentation/devicetree/bindings/mfd/syscon.txt
>>>> +
>>>> +Required properties:
>>>> +- compatible: "hisilicon,hi3519-sysctrl".
>>>> +- reg: the register region of this block
>>>> +
>>>> +Examples:
>>>> +sysctrl: system-controller@12010000 {
>>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon";
>>>> + reg = <0x12010000 0x1000>;
>>>> +};
>>>
>>> There is no requirement (nor want) for binding documents where the
>>> given device is simply using highly generic bindings. This just
>>> amounts to churn.
>>>
>> This block is specific for Hi3519 SOC, and may has its own driver.
>
> Does it have its own driver currently?
>
Not yet.
Arnd Bergmann and Rob Herring all suggested adding a specific compatible string
with the SOC name. This binding is just used for describing the compatible string now.
When more functions on hi3519 SOC are added later, the specific driver will be also
needed.
>> So I think it's better to keep this binding.
>
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-01-12 08:50 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qQ1Si-6do-13@gated-at.bofh.it> |
| In reply to | #1306905 |
On Tue, 12 Jan 2016, xuejiancheng wrote:
>
>
> On 2016/1/11 16:55, Lee Jones wrote:
> > On Mon, 11 Jan 2016, xuejiancheng wrote:
> >> On 2016/1/11 13:48, Lee Jones wrote:
> >>> On Fri, 08 Jan 2016, Jiancheng Xue wrote:
> >>>
> >>>> Add device tree bindings for Hi3519 system controller.
> >>>>
> >>>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
> >>>> ---
> >>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
> >>>> 1 file changed, 14 insertions(+)
> >>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>
> >>> I have this patch, but none of the others in the set, thus I am
> >>> lacking context.
> >>>
> >> I can forward other patches in the set to you. Thank you.
> >>
> >>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>> new file mode 100644
> >>>> index 0000000..115c5be
> >>>> --- /dev/null
> >>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>> @@ -0,0 +1,14 @@
> >>>> +* Hisilicon Hi3519 System Controller Block
> >>>> +
> >>>> +This bindings use the following binding:
> >>>> +Documentation/devicetree/bindings/mfd/syscon.txt
> >>>> +
> >>>> +Required properties:
> >>>> +- compatible: "hisilicon,hi3519-sysctrl".
> >>>> +- reg: the register region of this block
> >>>> +
> >>>> +Examples:
> >>>> +sysctrl: system-controller@12010000 {
> >>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon";
> >>>> + reg = <0x12010000 0x1000>;
> >>>> +};
> >>>
> >>> There is no requirement (nor want) for binding documents where the
> >>> given device is simply using highly generic bindings. This just
> >>> amounts to churn.
> >>>
> >> This block is specific for Hi3519 SOC, and may has its own driver.
> >
> > Does it have its own driver currently?
> >
> Not yet.
> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string
> with the SOC name. This binding is just used for describing the compatible string now.
> When more functions on hi3519 SOC are added later, the specific driver will be also
> needed.
Save this binding until it has more functionality. We here "I'll add
to this later" all too often.
> >> So I think it's better to keep this binding.
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | xuejiancheng <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-12 09:30 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qQ2v0-6Gt-9@gated-at.bofh.it> |
| In reply to | #1307057 |
Hello Lee,
On 2016/1/12 15:41, Lee Jones wrote:
> On Tue, 12 Jan 2016, xuejiancheng wrote:
>
>>
>>
>> On 2016/1/11 16:55, Lee Jones wrote:
>>> On Mon, 11 Jan 2016, xuejiancheng wrote:
>>>> On 2016/1/11 13:48, Lee Jones wrote:
>>>>> On Fri, 08 Jan 2016, Jiancheng Xue wrote:
>>>>>
>>>>>> Add device tree bindings for Hi3519 system controller.
>>>>>>
>>>>>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
>>>>>> ---
>>>>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
>>>>>> 1 file changed, 14 insertions(+)
>>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
>>>>>
>>>>> I have this patch, but none of the others in the set, thus I am
>>>>> lacking context.
>>>>>
>>>> I can forward other patches in the set to you. Thank you.
>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
>>>>>> new file mode 100644
>>>>>> index 0000000..115c5be
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
>>>>>> @@ -0,0 +1,14 @@
>>>>>> +* Hisilicon Hi3519 System Controller Block
>>>>>> +
>>>>>> +This bindings use the following binding:
>>>>>> +Documentation/devicetree/bindings/mfd/syscon.txt
>>>>>> +
>>>>>> +Required properties:
>>>>>> +- compatible: "hisilicon,hi3519-sysctrl".
>>>>>> +- reg: the register region of this block
>>>>>> +
>>>>>> +Examples:
>>>>>> +sysctrl: system-controller@12010000 {
>>>>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon";
>>>>>> + reg = <0x12010000 0x1000>;
>>>>>> +};
>>>>>
>>>>> There is no requirement (nor want) for binding documents where the
>>>>> given device is simply using highly generic bindings. This just
>>>>> amounts to churn.
>>>>>
>>>> This block is specific for Hi3519 SOC, and may has its own driver.
>>>
>>> Does it have its own driver currently?
>>>
>> Not yet.
>> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string
>> with the SOC name. This binding is just used for describing the compatible string now.
>> When more functions on hi3519 SOC are added later, the specific driver will be also
>> needed.
>
> Save this binding until it has more functionality. We here "I'll add
> to this later" all too often.
>
In the hi3519.dtsi file, there is a system-controller device node described like below:
sysctrl: system-controller@12010000 {
compatible = "hisilicon,hi3519-sysctrl", "syscon";
reg = <0x12010000 0x1000>;
};
Do you mean that I should remove "hisilicon,hi3519-sysctrl" and just use "syscon" as the
compatible string?
If I want to add "hisilicon,hi3519-sysctrl" for hi3519. where should I put this binding?
Could you give some suggestions? Thank you very much!
>>>> So I think it's better to keep this binding.
>>>
>>
>
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-01-12 09:50 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qQ2Om-6OM-25@gated-at.bofh.it> |
| In reply to | #1307085 |
On Tue, 12 Jan 2016, xuejiancheng wrote:
> Hello Lee,
>
> On 2016/1/12 15:41, Lee Jones wrote:
> > On Tue, 12 Jan 2016, xuejiancheng wrote:
> >
> >>
> >>
> >> On 2016/1/11 16:55, Lee Jones wrote:
> >>> On Mon, 11 Jan 2016, xuejiancheng wrote:
> >>>> On 2016/1/11 13:48, Lee Jones wrote:
> >>>>> On Fri, 08 Jan 2016, Jiancheng Xue wrote:
> >>>>>
> >>>>>> Add device tree bindings for Hi3519 system controller.
> >>>>>>
> >>>>>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
> >>>>>> ---
> >>>>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
> >>>>>> 1 file changed, 14 insertions(+)
> >>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>>>
> >>>>> I have this patch, but none of the others in the set, thus I am
> >>>>> lacking context.
> >>>>>
> >>>> I can forward other patches in the set to you. Thank you.
> >>>>
> >>>>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>>>> new file mode 100644
> >>>>>> index 0000000..115c5be
> >>>>>> --- /dev/null
> >>>>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>>>> @@ -0,0 +1,14 @@
> >>>>>> +* Hisilicon Hi3519 System Controller Block
> >>>>>> +
> >>>>>> +This bindings use the following binding:
> >>>>>> +Documentation/devicetree/bindings/mfd/syscon.txt
> >>>>>> +
> >>>>>> +Required properties:
> >>>>>> +- compatible: "hisilicon,hi3519-sysctrl".
> >>>>>> +- reg: the register region of this block
> >>>>>> +
> >>>>>> +Examples:
> >>>>>> +sysctrl: system-controller@12010000 {
> >>>>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon";
> >>>>>> + reg = <0x12010000 0x1000>;
> >>>>>> +};
> >>>>>
> >>>>> There is no requirement (nor want) for binding documents where the
> >>>>> given device is simply using highly generic bindings. This just
> >>>>> amounts to churn.
> >>>>>
> >>>> This block is specific for Hi3519 SOC, and may has its own driver.
> >>>
> >>> Does it have its own driver currently?
> >>>
> >> Not yet.
> >> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string
> >> with the SOC name. This binding is just used for describing the compatible string now.
> >> When more functions on hi3519 SOC are added later, the specific driver will be also
> >> needed.
> >
> > Save this binding until it has more functionality. We here "I'll add
> > to this later" all too often.
> >
>
> In the hi3519.dtsi file, there is a system-controller device node described like below:
> sysctrl: system-controller@12010000 {
> compatible = "hisilicon,hi3519-sysctrl", "syscon";
> reg = <0x12010000 0x1000>;
> };
> Do you mean that I should remove "hisilicon,hi3519-sysctrl" and just use "syscon" as the
> compatible string?
Where is this compatible string _used_?
> If I want to add "hisilicon,hi3519-sysctrl" for hi3519. where should I put this binding?
> Could you give some suggestions? Thank you very much!
If you're not using the compatible i.e. the device doesn't have its
own driver yet, then there is no need to supply the binding at all, is
there?
> >>>> So I think it's better to keep this binding.
> >>>
> >>
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | xuejiancheng <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-12 10:40 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qQ3AK-7rn-15@gated-at.bofh.it> |
| In reply to | #1307116 |
On 2016/1/12 16:39, Lee Jones wrote:
> On Tue, 12 Jan 2016, xuejiancheng wrote:
>
>> Hello Lee,
>>
>> On 2016/1/12 15:41, Lee Jones wrote:
>>> On Tue, 12 Jan 2016, xuejiancheng wrote:
>>>
>>>>
>>>>
>>>> On 2016/1/11 16:55, Lee Jones wrote:
>>>>> On Mon, 11 Jan 2016, xuejiancheng wrote:
>>>>>> On 2016/1/11 13:48, Lee Jones wrote:
>>>>>>> On Fri, 08 Jan 2016, Jiancheng Xue wrote:
>>>>>>>
>>>>>>>> Add device tree bindings for Hi3519 system controller.
>>>>>>>>
>>>>>>>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
>>>>>>>> ---
>>>>>>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
>>>>>>>> 1 file changed, 14 insertions(+)
>>>>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
>>>>>>>
>>>>>>> I have this patch, but none of the others in the set, thus I am
>>>>>>> lacking context.
>>>>>>>
>>>>>> I can forward other patches in the set to you. Thank you.
>>>>>>
>>>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
>>>>>>>> new file mode 100644
>>>>>>>> index 0000000..115c5be
>>>>>>>> --- /dev/null
>>>>>>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
>>>>>>>> @@ -0,0 +1,14 @@
>>>>>>>> +* Hisilicon Hi3519 System Controller Block
>>>>>>>> +
>>>>>>>> +This bindings use the following binding:
>>>>>>>> +Documentation/devicetree/bindings/mfd/syscon.txt
>>>>>>>> +
>>>>>>>> +Required properties:
>>>>>>>> +- compatible: "hisilicon,hi3519-sysctrl".
>>>>>>>> +- reg: the register region of this block
>>>>>>>> +
>>>>>>>> +Examples:
>>>>>>>> +sysctrl: system-controller@12010000 {
>>>>>>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon";
>>>>>>>> + reg = <0x12010000 0x1000>;
>>>>>>>> +};
>>>>>>>
>>>>>>> There is no requirement (nor want) for binding documents where the
>>>>>>> given device is simply using highly generic bindings. This just
>>>>>>> amounts to churn.
>>>>>>>
>>>>>> This block is specific for Hi3519 SOC, and may has its own driver.
>>>>>
>>>>> Does it have its own driver currently?
>>>>>
>>>> Not yet.
>>>> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string
>>>> with the SOC name. This binding is just used for describing the compatible string now.
>>>> When more functions on hi3519 SOC are added later, the specific driver will be also
>>>> needed.
>>>
>>> Save this binding until it has more functionality. We here "I'll add
>>> to this later" all too often.
>>>
>>
>> In the hi3519.dtsi file, there is a system-controller device node described like below:
>> sysctrl: system-controller@12010000 {
>> compatible = "hisilicon,hi3519-sysctrl", "syscon";
>> reg = <0x12010000 0x1000>;
>> };
>> Do you mean that I should remove "hisilicon,hi3519-sysctrl" and just use "syscon" as the
>> compatible string?
>
> Where is this compatible string _used_?
>
>> If I want to add "hisilicon,hi3519-sysctrl" for hi3519. where should I put this binding?
>> Could you give some suggestions? Thank you very much!
>
> If you're not using the compatible i.e. the device doesn't have its
> own driver yet, then there is no need to supply the binding at all, is
> there?
>
OK. Thank you.
>>>>>> So I think it's better to keep this binding.
>>>>>
>>>>
>>>
>>
>
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-01-13 00:00 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qQg4W-7wg-5@gated-at.bofh.it> |
| In reply to | #1307155 |
On Tuesday 12 January 2016 17:28:05 xuejiancheng wrote:
> >>>>>
> >>>> Not yet.
> >>>> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string
> >>>> with the SOC name. This binding is just used for describing the compatible string now.
> >>>> When more functions on hi3519 SOC are added later, the specific driver will be also
> >>>> needed.
> >>>
> >>> Save this binding until it has more functionality. We here "I'll add
> >>> to this later" all too often.
> >>>
> >>
> >> In the hi3519.dtsi file, there is a system-controller device node described like below:
> >> sysctrl: system-controller@12010000 {
> >> compatible = "hisilicon,hi3519-sysctrl", "syscon";
> >> reg = <0x12010000 0x1000>;
> >> };
> >> Do you mean that I should remove "hisilicon,hi3519-sysctrl" and just use "syscon" as the
> >> compatible string?
> >
> > Where is this compatible string _used_?
> >
> >> If I want to add "hisilicon,hi3519-sysctrl" for hi3519. where should I put this binding?
> >> Could you give some suggestions? Thank you very much!
> >
> > If you're not using the compatible i.e. the device doesn't have its
> > own driver yet, then there is no need to supply the binding at all, is
> > there?
> >
>
> OK. Thank you.
>
Sorry for stepping in late here. I still think that every syscon device should
come with a specific compatible string, so we have the option of creating a
driver later on, and I'd like to see a binding document that lists those strings
(which I believe exists here).
It's really hard to add compatible strings later on, anything else we can
work around by keying off that string and adding a workaround in the kernel.
Arnd
[toc] | [prev] | [next] | [standalone]
| From | xuejiancheng <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-13 10:30 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qQpUD-63W-11@gated-at.bofh.it> |
| In reply to | #1307902 |
Hi Arnd,
On 2016/1/13 6:51, Arnd Bergmann wrote:
> On Tuesday 12 January 2016 17:28:05 xuejiancheng wrote:
>>>>>>>
>>>>>> Not yet.
>>>>>> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string
>>>>>> with the SOC name. This binding is just used for describing the compatible string now.
>>>>>> When more functions on hi3519 SOC are added later, the specific driver will be also
>>>>>> needed.
>>>>>
>>>>> Save this binding until it has more functionality. We here "I'll add
>>>>> to this later" all too often.
>>>>>
>>>>
>>>> In the hi3519.dtsi file, there is a system-controller device node described like below:
>>>> sysctrl: system-controller@12010000 {
>>>> compatible = "hisilicon,hi3519-sysctrl", "syscon";
>>>> reg = <0x12010000 0x1000>;
>>>> };
>>>> Do you mean that I should remove "hisilicon,hi3519-sysctrl" and just use "syscon" as the
>>>> compatible string?
>>>
>>> Where is this compatible string _used_?
>>>
>>>> If I want to add "hisilicon,hi3519-sysctrl" for hi3519. where should I put this binding?
>>>> Could you give some suggestions? Thank you very much!
>>>
>>> If you're not using the compatible i.e. the device doesn't have its
>>> own driver yet, then there is no need to supply the binding at all, is
>>> there?
>>>
>>
>> OK. Thank you.
>>
>
> Sorry for stepping in late here. I still think that every syscon device should
> come with a specific compatible string, so we have the option of creating a
> driver later on, and I'd like to see a binding document that lists those strings
> (which I believe exists here).
>
> It's really hard to add compatible strings later on, anything else we can
> work around by keying off that string and adding a workaround in the kernel.
>
Is it OK if I put this binding document into the directory "Documentation/devicetree/bindings/arm/hisilicon"?
Thank you.
> Arnd
>
> .
>
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-01-13 11:10 +0100 |
| Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| Message-ID | <qQqxj-6Bo-5@gated-at.bofh.it> |
| In reply to | #1308201 |
On Wednesday 13 January 2016 17:08:20 xuejiancheng wrote: > > > > Is it OK if I put this binding document into the directory "Documentation/devicetree/bindings/arm/hisilicon"? > Yes, sounds good. Arnd
[toc] | [prev] | [next] | [standalone]
| From | Jiancheng Xue <xuejiancheng@huawei.com> |
|---|---|
| Date | 2016-01-08 03:40 +0100 |
| Subject | [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 |
| Message-ID | <qOv86-7I-17@gated-at.bofh.it> |
| In reply to | #1304135 |
add dts files for Hi3519
Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
---
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/hi3519-demb.dts | 42 +++++++++
arch/arm/boot/dts/hi3519.dtsi | 175 ++++++++++++++++++++++++++++++++++++++
3 files changed, 219 insertions(+)
create mode 100644 arch/arm/boot/dts/hi3519-demb.dts
create mode 100644 arch/arm/boot/dts/hi3519.dtsi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 30bbc37..1ff3ed9 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -135,6 +135,8 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \
exynos5800-peach-pi.dtb
dtb-$(CONFIG_ARCH_HI3xxx) += \
hi3620-hi4511.dtb
+dtb-$(CONFIG_ARCH_HISI) += \
+ hi3519-demb.dtb
dtb-$(CONFIG_ARCH_HIX5HD2) += \
hisi-x5hd2-dkb.dtb
dtb-$(CONFIG_ARCH_HIGHBANK) += \
diff --git a/arch/arm/boot/dts/hi3519-demb.dts b/arch/arm/boot/dts/hi3519-demb.dts
new file mode 100644
index 0000000..6991ab6
--- /dev/null
+++ b/arch/arm/boot/dts/hi3519-demb.dts
@@ -0,0 +1,42 @@
+/*
+ * Copyright (c) 2015 HiSilicon Technologies Co., Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+/dts-v1/;
+#include "hi3519.dtsi"
+
+/ {
+ model = "HiSilicon HI3519 DEMO Board";
+ compatible = "hisilicon,hi3519";
+
+ aliases {
+ serial0 = &uart0;
+ };
+
+ memory {
+ device_type = "memory";
+ reg = <0x80000000 0x40000000>;
+ };
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&dual_timer0 {
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/hi3519.dtsi b/arch/arm/boot/dts/hi3519.dtsi
new file mode 100644
index 0000000..95137c7
--- /dev/null
+++ b/arch/arm/boot/dts/hi3519.dtsi
@@ -0,0 +1,175 @@
+/*
+ * Copyright (c) 2015 HiSilicon Technologies Co., Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include <dt-bindings/clock/hi3519-clock.h>
+/ {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ chosen { };
+
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ cpu@0 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0>;
+ };
+ };
+
+ gic: interrupt-controller@10300000 {
+ compatible = "arm,cortex-a7-gic";
+ #interrupt-cells = <3>;
+ interrupt-controller;
+ reg = <0x10301000 0x1000>, <0x10302000 0x1000>;
+ };
+
+ soc {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "simple-bus";
+ interrupt-parent = <&gic>;
+ ranges;
+
+
+ uart0: serial@12100000 {
+ compatible = "arm,pl011", "arm,primecell";
+ reg = <0x12100000 0x1000>;
+ interrupts = <0 4 4>;
+ clocks = <&crg HI3519_UART0_CLK>;
+ clock-names = "apb_pclk";
+ status = "disable";
+ };
+
+ uart1: serial@12101000 {
+ compatible = "arm,pl011", "arm,primecell";
+ reg = <0x12101000 0x1000>;
+ interrupts = <0 5 4>;
+ clocks = <&crg HI3519_UART1_CLK>;
+ clock-names = "apb_pclk";
+ status = "disable";
+ };
+
+ uart2: serial@12102000 {
+ compatible = "arm,pl011", "arm,primecell";
+ reg = <0x12102000 0x1000>;
+ interrupts = <0 6 4>;
+ clocks = <&crg HI3519_UART2_CLK>;
+ clock-names = "apb_pclk";
+ status = "disable";
+ };
+
+ uart3: serial@12103000 {
+ compatible = "arm,pl011", "arm,primecell";
+ reg = <0x12103000 0x1000>;
+ interrupts = <0 7 4>;
+ clocks = <&crg HI3519_UART3_CLK>;
+ clock-names = "apb_pclk";
+ status = "disable";
+ };
+
+ uart4: serial@12104000 {
+ compatible = "arm,pl011", "arm,primecell";
+ reg = <0x12104000 0x1000>;
+ interrupts = <0 8 4>;
+ clocks = <&crg HI3519_UART4_CLK>;
+ clock-names = "apb_pclk";
+ status = "disable";
+ };
+
+ dual_timer0: timer@12000000 {
+ compatible = "arm,sp804", "arm,primecell";
+ interrupts = <0 64 4>, <0 65 4>;
+ reg = <0x12000000 0x1000>;
+ clocks = <&crg HI3519_FIXED_3M>;
+ status = "disable";
+ };
+
+ dual_timer1: timer@12001000 {
+ compatible = "arm,sp804", "arm,primecell";
+ interrupts = <0 66 4>, <0 67 4>;
+ reg = <0x12001000 0x1000>;
+ clocks = <&crg HI3519_FIXED_3M>;
+ status = "disable";
+ };
+
+ dual_timer2: timer@12002000 {
+ compatible = "arm,sp804", "arm,primecell";
+ interrupts = <0 68 4>, <0 69 4>;
+ reg = <0x12002000 0x1000>;
+ clocks = <&crg HI3519_FIXED_3M>;
+ status = "disable";
+ };
+
+ spi_bus0: spi@12120000 {
+ compatible = "arm,pl022", "arm,primecell";
+ reg = <0x12120000 0x1000>;
+ interrupts = <0 9 4>;
+ clocks = <&crg HI3519_SPI0_CLK>;
+ clock-names = "apb_pclk";
+ num-cs = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disable";
+ };
+
+ spi_bus1: spi@12121000 {
+ compatible = "arm,pl022", "arm,primecell";
+ reg = <0x12121000 0x1000>;
+ interrupts = <0 10 4>;
+ clocks = <&crg HI3519_SPI1_CLK>;
+ clock-names = "apb_pclk";
+ num-cs = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disable";
+ };
+
+ spi_bus2: spi@12122000 {
+ compatible = "arm,pl022", "arm,primecell";
+ reg = <0x12122000 0x1000>;
+ interrupts = <0 11 4>;
+ clocks = <&crg HI3519_SPI2_CLK>;
+ clock-names = "apb_pclk";
+ num-cs = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disable";
+ };
+
+ sysctrl: system-controller@12020000 {
+ compatible = "hisilicon,hi3519-sysctrl", "syscon";
+ reg = <0x12020000 0x1000>;
+ };
+
+ reboot {
+ compatible = "syscon-reboot";
+ regmap = <&sysctrl>;
+ offset = <0x4>;
+ mask = <0xdeadbeef>;
+ };
+
+ crg: clock-reset-controller@12010000 {
+ compatible = "hisilicon,hi3519-crg";
+ #clock-cells = <1>;
+ #reset-cells = <2>;
+ reg = <0x12010000 0x10000>;
+ };
+ };
+};
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Russell King - ARM Linux <linux@arm.linux.org.uk> |
|---|---|
| Date | 2016-01-08 16:20 +0100 |
| Subject | Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 |
| Message-ID | <qOGZz-8vi-5@gated-at.bofh.it> |
| In reply to | #1304142 |
On Fri, Jan 08, 2016 at 10:16:40AM +0800, Jiancheng Xue wrote:
> + uart0: serial@12100000 {
> + compatible = "arm,pl011", "arm,primecell";
> + reg = <0x12100000 0x1000>;
> + interrupts = <0 4 4>;
Should the last digit there be IRQ_TYPE_LEVEL_HIGH (and same for the
other interrupts= after this?)
Thanks.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
[toc] | [prev] | [next] | [standalone]
Page 1 of 2 [1] 2 Next page →
Back to top | Article view | linux.kernel
csiph-web