Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1307057

Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl

Show all headers | View raw

On Tue, 12 Jan 2016, xuejiancheng wrote:

> 
> 
> On 2016/1/11 16:55, Lee Jones wrote:
> > On Mon, 11 Jan 2016, xuejiancheng wrote:
> >> On 2016/1/11 13:48, Lee Jones wrote:
> >>> On Fri, 08 Jan 2016, Jiancheng Xue wrote:
> >>>
> >>>> Add device tree bindings for Hi3519 system controller.
> >>>>
> >>>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
> >>>> ---
> >>>>  Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++
> >>>>  1 file changed, 14 insertions(+)
> >>>>  create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>
> >>> I have this patch, but none of the others in the set, thus I am
> >>> lacking context.
> >>>
> >> I can forward other patches in the set to you. Thank you.
> >>
> >>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>> new file mode 100644
> >>>> index 0000000..115c5be
> >>>> --- /dev/null
> >>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt
> >>>> @@ -0,0 +1,14 @@
> >>>> +* Hisilicon Hi3519 System Controller Block
> >>>> +
> >>>> +This bindings use the following binding:
> >>>> +Documentation/devicetree/bindings/mfd/syscon.txt
> >>>> +
> >>>> +Required properties:
> >>>> +- compatible: "hisilicon,hi3519-sysctrl".
> >>>> +- reg: the register region of this block
> >>>> +
> >>>> +Examples:
> >>>> +sysctrl: system-controller@12010000 {
> >>>> +	compatible = "hisilicon,hi3519-sysctrl", "syscon";
> >>>> +	reg = <0x12010000 0x1000>;
> >>>> +};
> >>>
> >>> There is no requirement (nor want) for binding documents where the
> >>> given device is simply using highly generic bindings.  This just
> >>> amounts to churn.
> >>>
> >> This block is specific for Hi3519 SOC, and may has its own driver.
> > 
> > Does it have its own driver currently?
> > 
> Not yet.
> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string
> with the SOC name. This binding is just used for describing the compatible string now.
> When more functions on hi3519 SOC are added later, the specific driver will be also
> needed.

Save this binding until it has more functionality.  We here "I'll add
to this later" all too often.

> >> So I think it's better to keep this binding.
> > 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/6] ARM: hisi: Add initial support including clock driver for Hi3519 soc. Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:30 +0100
  [PATCH v5 4/6] ARM: debug: add hi3519 debug uart Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
    Re: [PATCH v5 4/6] ARM: debug: add hi3519 debug uart Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-08 16:10 +0100
      Re: [PATCH v5 4/6] ARM: debug: add hi3519 debug uart xuejiancheng <xuejiancheng@huawei.com> - 2016-01-11 03:50 +0100
  [PATCH v5 3/6] ARM: config: hisi: enable CONFIG_RESET_CONTROLLER Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
  [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
    Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl Rob Herring <robh@kernel.org> - 2016-01-08 22:10 +0100
    Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-11 06:50 +0100
      Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-11 09:00 +0100
        Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-11 10:00 +0100
          Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-12 02:40 +0100
            Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-12 08:50 +0100
              Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-12 09:30 +0100
                Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-12 09:50 +0100
                Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-12 10:40 +0100
                Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Arnd Bergmann <arnd@arndb.de> - 2016-01-13 00:00 +0100
                Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-13 10:30 +0100
                Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Arnd Bergmann <arnd@arndb.de> - 2016-01-13 11:10 +0100
  [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
    Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-08 16:20 +0100
      Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 xuejiancheng <xuejiancheng@huawei.com> - 2016-01-11 03:10 +0100

csiph-web