Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1308201

Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl

Show all headers | View raw

Hi Arnd,

On 2016/1/13 6:51, Arnd Bergmann wrote:
> On Tuesday 12 January 2016 17:28:05 xuejiancheng wrote:
>>>>>>>
>>>>>> Not yet.
>>>>>> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string
>>>>>> with the SOC name. This binding is just used for describing the compatible string now.
>>>>>> When more functions on hi3519 SOC are added later, the specific driver will be also
>>>>>> needed.
>>>>>
>>>>> Save this binding until it has more functionality.  We here "I'll add
>>>>> to this later" all too often.
>>>>>
>>>>
>>>> In the hi3519.dtsi file, there is a system-controller device node described like below:
>>>> sysctrl: system-controller@12010000 {
>>>>      compatible = "hisilicon,hi3519-sysctrl", "syscon";
>>>>      reg = <0x12010000 0x1000>;
>>>> };
>>>> Do you mean that I should remove "hisilicon,hi3519-sysctrl" and just use "syscon" as the
>>>> compatible string?　
>>>
>>> Where is this compatible string _used_?
>>>
>>>> If I want to add "hisilicon,hi3519-sysctrl" for hi3519. where should I put this binding?
>>>> Could you give some suggestions?  Thank you very much!
>>>
>>> If you're not using the compatible i.e. the device doesn't have its
>>> own driver yet, then there is no need to supply the binding at all, is
>>> there?
>>>
>>
>> OK. Thank you.
>>
> 
> Sorry for stepping in late here. I still think that every syscon device should
> come with a specific compatible string, so we have the option of creating a
> driver later on, and I'd like to see a binding document that lists those strings
> (which I believe exists here).
> 
> It's really hard to add compatible strings later on, anything else we can
> work around by keying off that string and adding a workaround in the kernel.
> 

Is it OK if I put this binding document into the directory "Documentation/devicetree/bindings/arm/hisilicon"?

Thank you.

> 	Arnd
> 
> .
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/6] ARM: hisi: Add initial support including clock driver for Hi3519 soc. Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:30 +0100
  [PATCH v5 4/6] ARM: debug: add hi3519 debug uart Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
    Re: [PATCH v5 4/6] ARM: debug: add hi3519 debug uart Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-08 16:10 +0100
      Re: [PATCH v5 4/6] ARM: debug: add hi3519 debug uart xuejiancheng <xuejiancheng@huawei.com> - 2016-01-11 03:50 +0100
  [PATCH v5 3/6] ARM: config: hisi: enable CONFIG_RESET_CONTROLLER Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
  [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
    Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl Rob Herring <robh@kernel.org> - 2016-01-08 22:10 +0100
    Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-11 06:50 +0100
      Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-11 09:00 +0100
        Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-11 10:00 +0100
          Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-12 02:40 +0100
            Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-12 08:50 +0100
              Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-12 09:30 +0100
                Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl Lee Jones <lee.jones@linaro.org> - 2016-01-12 09:50 +0100
                Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-12 10:40 +0100
                Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Arnd Bergmann <arnd@arndb.de> - 2016-01-13 00:00 +0100
                Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for  Hi3519 sysctrl xuejiancheng <xuejiancheng@huawei.com> - 2016-01-13 10:30 +0100
                Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Arnd Bergmann <arnd@arndb.de> - 2016-01-13 11:10 +0100
  [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 Jiancheng Xue <xuejiancheng@huawei.com> - 2016-01-08 03:40 +0100
    Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-08 16:20 +0100
      Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 xuejiancheng <xuejiancheng@huawei.com> - 2016-01-11 03:10 +0100

csiph-web