Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305550 > unrolled thread

[PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

Started byMans Rullgard <mans@mansr.com>
First post2016-01-10 13:50 +0100
Last post2016-01-10 20:10 +0100
Articles 8 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Mans Rullgard <mans@mansr.com> - 2016-01-10 13:50 +0100
    Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on  pwm2 Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-10 14:10 +0100
      Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Måns Rullgård <mans@mansr.com> - 2016-01-10 14:20 +0100
        Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on  pwm2 Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-10 14:40 +0100
          Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Måns Rullgård <mans@mansr.com> - 2016-01-10 14:50 +0100
            Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on  pwm2 Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-10 15:00 +0100
              Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Måns Rullgård <mans@mansr.com> - 2016-01-10 15:10 +0100
          Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-01-10 20:10 +0100

#1305550 — [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

FromMans Rullgard <mans@mansr.com>
Date2016-01-10 13:50 +0100
Subject[PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
Message-ID<qPnBv-4eS-9@gated-at.bofh.it>
Add pinmux setting for USB1 overcurrent on pwm2 pad.

Signed-off-by: Mans Rullgard <mans@mansr.com>
---
 arch/arm/boot/dts/imx28.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index fae7b9069fc4..2f5cbf7d09f2 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -883,6 +883,16 @@
 					fsl,pull-up = <MXS_PULL_DISABLE>;
 				};
 
+				usb1_pins_b: usb1@1 {
+					reg = <1>;
+					fsl,pinmux-ids = <
+						MX28_PAD_PWM2__USB1_OVERCURRENT
+					>;
+					fsl,drive-strength = <MXS_DRIVE_12mA>;
+					fsl,voltage = <MXS_VOLTAGE_HIGH>;
+					fsl,pull-up = <MXS_PULL_DISABLE>;
+				};
+
 				usb0_id_pins_a: usb0id@0 {
 					reg = <0>;
 					fsl,pinmux-ids = <
-- 
2.7.0

[toc] | [next] | [standalone]

#1305551 — Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-01-10 14:10 +0100
SubjectRe: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
Message-ID<qPnUR-4Ak-1@gated-at.bofh.it>
In reply to#1305550
Hi Mans,

> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
>
>
> Add pinmux setting for USB1 overcurrent on pwm2 pad.

could you please change your patch to describe why you need to add this pinmux?

>
> Signed-off-by: Mans Rullgard <mans@mansr.com>

Thanks Stefan

[toc] | [prev] | [next] | [standalone]

#1305555

FromMåns Rullgård <mans@mansr.com>
Date2016-01-10 14:20 +0100
Message-ID<qPo4z-4DC-25@gated-at.bofh.it>
In reply to#1305551
Stefan Wahren <stefan.wahren@i2se.com> writes:

> Hi Mans,
>
>> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
>>
>>
>> Add pinmux setting for USB1 overcurrent on pwm2 pad.
>
> could you please change your patch to describe why you need to add
> this pinmux?

I'm working on a board that is wired that way.  I can of course put this
in the board-specific dts if that's preferable.

-- 
Måns Rullgård

[toc] | [prev] | [next] | [standalone]

#1305558 — Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-01-10 14:40 +0100
SubjectRe: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
Message-ID<qPonU-4Lw-5@gated-at.bofh.it>
In reply to#1305555
> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
>
>
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
> > Hi Mans,
> >
> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
> >>
> >>
> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> >
> > could you please change your patch to describe why you need to add
> > this pinmux?
>
> I'm working on a board that is wired that way. I can of course put this
> in the board-specific dts if that's preferable.

So the board isn't submitted to mainline?

IMHO the change is okay, but the description doesn't explain why is it needed.

So a suitable description would be that it's needed for board xy.

>
> --
> Måns Rullgård

[toc] | [prev] | [next] | [standalone]

#1305560

FromMåns Rullgård <mans@mansr.com>
Date2016-01-10 14:50 +0100
Message-ID<qPoxA-4PG-3@gated-at.bofh.it>
In reply to#1305558
Stefan Wahren <stefan.wahren@i2se.com> writes:

>> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
>>
>>
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>>
>> > Hi Mans,
>> >
>> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
>> >>
>> >>
>> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
>> >
>> > could you please change your patch to describe why you need to add
>> > this pinmux?
>>
>> I'm working on a board that is wired that way. I can of course put this
>> in the board-specific dts if that's preferable.
>
> So the board isn't submitted to mainline?

Not yet anyway.

> IMHO the change is okay, but the description doesn't explain why is it needed.
>
> So a suitable description would be that it's needed for board xy.

Would it be better to send this patch in a series along with the full
board support?

-- 
Måns Rullgård

[toc] | [prev] | [next] | [standalone]

#1305562 — Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-01-10 15:00 +0100
SubjectRe: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
Message-ID<qPoHh-4Tm-17@gated-at.bofh.it>
In reply to#1305560
> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:42 geschrieben:
>
>
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
> >> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
> >>
> >>
> >> Stefan Wahren <stefan.wahren@i2se.com> writes:
> >>
> >> > Hi Mans,
> >> >
> >> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40
> >> >> geschrieben:
> >> >>
> >> >>
> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> >> >
> >> > could you please change your patch to describe why you need to add
> >> > this pinmux?
> >>
> >> I'm working on a board that is wired that way. I can of course put this
> >> in the board-specific dts if that's preferable.
> >
> > So the board isn't submitted to mainline?
>
> Not yet anyway.
>
> > IMHO the change is okay, but the description doesn't explain why is it
> > needed.
> >
> > So a suitable description would be that it's needed for board xy.
>
> Would it be better to send this patch in a series along with the full
> board support?
>

Yes, it would be nice to have a dts file which reference the new pinmux.

> --
> Måns Rullgård
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[toc] | [prev] | [next] | [standalone]

#1305563

FromMåns Rullgård <mans@mansr.com>
Date2016-01-10 15:10 +0100
Message-ID<qPoQV-5c3-1@gated-at.bofh.it>
In reply to#1305562
Stefan Wahren <stefan.wahren@i2se.com> writes:

>> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:42 geschrieben:
>>
>>
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>>
>> >> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
>> >>
>> >>
>> >> Stefan Wahren <stefan.wahren@i2se.com> writes:
>> >>
>> >> > Hi Mans,
>> >> >
>> >> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40
>> >> >> geschrieben:
>> >> >>
>> >> >>
>> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
>> >> >
>> >> > could you please change your patch to describe why you need to add
>> >> > this pinmux?
>> >>
>> >> I'm working on a board that is wired that way. I can of course put this
>> >> in the board-specific dts if that's preferable.
>> >
>> > So the board isn't submitted to mainline?
>>
>> Not yet anyway.
>>
>> > IMHO the change is okay, but the description doesn't explain why is it
>> > needed.
>> >
>> > So a suitable description would be that it's needed for board xy.
>>
>> Would it be better to send this patch in a series along with the full
>> board support?
>>
>
> Yes, it would be nice to have a dts file which reference the new pinmux.

OK, I'll sit on it for a while longer then.

-- 
Måns Rullgård

[toc] | [prev] | [next] | [standalone]

#1305654

FromUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date2016-01-10 20:10 +0100
Message-ID<qPtxg-8hk-3@gated-at.bofh.it>
In reply to#1305558
Hello,

On Sun, Jan 10, 2016 at 02:38:00PM +0100, Stefan Wahren wrote:
> > Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
> > Stefan Wahren <stefan.wahren@i2se.com> writes:
> >
> > > Hi Mans,
> > >
> > >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
> > >>
> > >>
> > >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> > >
> > > could you please change your patch to describe why you need to add
> > > this pinmux?
> >
> > I'm working on a board that is wired that way. I can of course put this
> > in the board-specific dts if that's preferable.
> 
> So the board isn't submitted to mainline?
> 
> IMHO the change is okay, but the description doesn't explain why is it needed.
> 
> So a suitable description would be that it's needed for board xy.

The problem with pinmuxing on i.MX23/28 is that the order of pinmux
groups is to a certain degree important. So not everything is possible
in the machine specific dts. (I didn't have an eye on this issue, maybe
it's fixed in the meantime?)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web