Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

From	Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
Date	2016-01-10 20:10 +0100
Message-ID	<qPtxg-8hk-3@gated-at.bofh.it> (permalink)
References	<qPnBv-4eS-9@gated-at.bofh.it> <qPnUR-4Ak-1@gated-at.bofh.it> <qPo4z-4DC-25@gated-at.bofh.it> <qPonU-4Lw-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Sun, Jan 10, 2016 at 02:38:00PM +0100, Stefan Wahren wrote:
> > Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
> > Stefan Wahren <stefan.wahren@i2se.com> writes:
> >
> > > Hi Mans,
> > >
> > >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40 geschrieben:
> > >>
> > >>
> > >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
> > >
> > > could you please change your patch to describe why you need to add
> > > this pinmux?
> >
> > I'm working on a board that is wired that way. I can of course put this
> > in the board-specific dts if that's preferable.
> 
> So the board isn't submitted to mainline?
> 
> IMHO the change is okay, but the description doesn't explain why is it needed.
> 
> So a suitable description would be that it's needed for board xy.

The problem with pinmuxing on i.MX23/28 is that the order of pinmux
groups is to a certain degree important. So not everything is possible
in the machine specific dts. (I didn't have an eye on this issue, maybe
it's fixed in the meantime?)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Mans Rullgard <mans@mansr.com> - 2016-01-10 13:50 +0100
  Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on  pwm2 Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-10 14:10 +0100
    Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Måns Rullgård <mans@mansr.com> - 2016-01-10 14:20 +0100
      Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on  pwm2 Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-10 14:40 +0100
        Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Måns Rullgård <mans@mansr.com> - 2016-01-10 14:50 +0100
          Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on  pwm2 Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-10 15:00 +0100
            Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Måns Rullgård <mans@mansr.com> - 2016-01-10 15:10 +0100
        Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-01-10 20:10 +0100

csiph-web