Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1305563

Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

From Måns Rullgård <mans@mansr.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
Date 2016-01-10 15:10 +0100
Message-ID <qPoQV-5c3-1@gated-at.bofh.it> (permalink)
References (1 earlier) <qPnUR-4Ak-1@gated-at.bofh.it> <qPo4z-4DC-25@gated-at.bofh.it> <qPonU-4Lw-5@gated-at.bofh.it> <qPoxA-4PG-3@gated-at.bofh.it> <qPoHh-4Tm-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Stefan Wahren <stefan.wahren@i2se.com> writes:

>> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:42 geschrieben:
>>
>>
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>>
>> >> Måns Rullgård <mans@mansr.com> hat am 10. Januar 2016 um 14:13 geschrieben:
>> >>
>> >>
>> >> Stefan Wahren <stefan.wahren@i2se.com> writes:
>> >>
>> >> > Hi Mans,
>> >> >
>> >> >> Mans Rullgard <mans@mansr.com> hat am 10. Januar 2016 um 13:40
>> >> >> geschrieben:
>> >> >>
>> >> >>
>> >> >> Add pinmux setting for USB1 overcurrent on pwm2 pad.
>> >> >
>> >> > could you please change your patch to describe why you need to add
>> >> > this pinmux?
>> >>
>> >> I'm working on a board that is wired that way. I can of course put this
>> >> in the board-specific dts if that's preferable.
>> >
>> > So the board isn't submitted to mainline?
>>
>> Not yet anyway.
>>
>> > IMHO the change is okay, but the description doesn't explain why is it
>> > needed.
>> >
>> > So a suitable description would be that it's needed for board xy.
>>
>> Would it be better to send this patch in a series along with the full
>> board support?
>>
>
> Yes, it would be nice to have a dts file which reference the new pinmux.

OK, I'll sit on it for a while longer then.

-- 
Måns Rullgård

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Mans Rullgard <mans@mansr.com> - 2016-01-10 13:50 +0100
  Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on  pwm2 Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-10 14:10 +0100
    Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Måns Rullgård <mans@mansr.com> - 2016-01-10 14:20 +0100
      Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on  pwm2 Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-10 14:40 +0100
        Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Måns Rullgård <mans@mansr.com> - 2016-01-10 14:50 +0100
          Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on  pwm2 Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-10 15:00 +0100
            Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Måns Rullgård <mans@mansr.com> - 2016-01-10 15:10 +0100
        Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-01-10 20:10 +0100

csiph-web