Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1219653 > unrolled thread
| Started by | Alexey Klimov <alexey.klimov@linaro.org> |
|---|---|
| First post | 2015-09-06 00:50 +0200 |
| Last post | 2015-09-07 12:20 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree" Alexey Klimov <alexey.klimov@linaro.org> - 2015-09-06 00:50 +0200
Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree" Mark Brown <broonie@kernel.org> - 2015-09-06 02:10 +0200
Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree" Alexey Klimov <klimov.linux@gmail.com> - 2015-09-06 02:30 +0200
Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree" Mark Brown <broonie@kernel.org> - 2015-09-07 12:20 +0200
| From | Alexey Klimov <alexey.klimov@linaro.org> |
|---|---|
| Date | 2015-09-06 00:50 +0200 |
| Subject | [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree" |
| Message-ID | <q5urv-5CW-1@gated-at.bofh.it> |
Hi all, During review of new SPI drivers I tried to understand connection between comment "calling spi_master_put() and kfree() to prevent a memory leak" for spi_alloc_master() in spi.c and why no driver calls kfree() on error path. Looks like Uwe added this comment and later I found patch from Guenter that reverted this comment but spi-imx.c was not fixed for that time. Later in 2013 spi-imx was fixed. Is it correct time right now to fix comment? I tried to save authorship of patch from Guenter, added field "From" and kept signed-off-by and cc. I hope i did it correctly in patch (sorry for possible inconvenience). Also marked it as RESEND since it's resend of original patch from 2012 year. Best regards, Alexey Klimov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-09-06 02:10 +0200 |
| Subject | Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree" |
| Message-ID | <q5vGV-7yK-13@gated-at.bofh.it> |
| In reply to | #1219653 |
[Multipart message — attachments visible in raw view] — view raw
On Sun, Sep 06, 2015 at 01:47:21AM +0300, Alexey Klimov wrote: > During review of new SPI drivers I tried to understand connection > between comment "calling spi_master_put() and kfree() to prevent a > memory leak" for spi_alloc_master() in spi.c and why no driver calls > kfree() on error path. Looks like Uwe added this comment and later I > found patch from Guenter that reverted this comment but spi-imx.c was > not fixed for that time. Later in 2013 spi-imx was fixed. Is it > correct time right now to fix comment? I'm sorry but I'm not clear what you're talking about here as there's missing context... where is this comment you're talking about? In general please don't send cover letters for single patches, either add the content to the commit message or put it after the --- if it's administrative stuff (like SubmittingPatches says).
[toc] | [prev] | [next] | [standalone]
| From | Alexey Klimov <klimov.linux@gmail.com> |
|---|---|
| Date | 2015-09-06 02:30 +0200 |
| Subject | Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree" |
| Message-ID | <q5w0h-7V2-1@gated-at.bofh.it> |
| In reply to | #1219657 |
On Sun, Sep 6, 2015 at 3:06 AM, Mark Brown <broonie@kernel.org> wrote: > On Sun, Sep 06, 2015 at 01:47:21AM +0300, Alexey Klimov wrote: > >> During review of new SPI drivers I tried to understand connection >> between comment "calling spi_master_put() and kfree() to prevent a >> memory leak" for spi_alloc_master() in spi.c and why no driver calls >> kfree() on error path. Looks like Uwe added this comment and later I >> found patch from Guenter that reverted this comment but spi-imx.c was >> not fixed for that time. Later in 2013 spi-imx was fixed. Is it >> correct time right now to fix comment? > > I'm sorry but I'm not clear what you're talking about here as there's > missing context... where is this comment you're talking about? > > In general please don't send cover letters for single patches, either > add the content to the commit message or put it after the --- if it's > administrative stuff (like SubmittingPatches says). Okay, understand (about formatting of subject, RESEND noise and no cover letter for single patches). Just never send reverts before (especially when it's re-send from 2012 year). It's easy to see comment in patch with subject: [PATCH RESEND 1/1] Revert "spi/doc: spi_master_put must be followed up by kfree" It's in drivers/spi/spi.c, line 1440 in tag v4.2 released ~ 5 days ago. Comment for function spi_alloc_master(). Sorry. Right now I see how I screwed up. Should I re-send it as single patch with all info included (marking as RESEND)? -- Best regards, Klimov Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-09-07 12:20 +0200 |
| Subject | Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree" |
| Message-ID | <q61GO-2Bq-7@gated-at.bofh.it> |
| In reply to | #1219661 |
[Multipart message — attachments visible in raw view] — view raw
On Sun, Sep 06, 2015 at 03:22:43AM +0300, Alexey Klimov wrote: > Sorry. Right now I see how I screwed up. Should I re-send it as single > patch with all info included (marking as RESEND)? No, it's OK - the patch itself was clear enough and I already applied it.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web