Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219653

[PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed up by kfree"

Show all headers | View raw

Hi all,

During review of new SPI drivers I tried to understand connection
between comment "calling spi_master_put() and kfree() to prevent a
memory leak" for spi_alloc_master() in spi.c and why no driver calls
kfree() on error path. Looks like Uwe added this comment and later I
found patch from Guenter that reverted this comment but spi-imx.c was
not fixed for that time. Later in 2013 spi-imx was fixed. Is it
correct time right now to fix comment?

I tried to save authorship of patch from Guenter, added field "From"
and kept signed-off-by and cc. I hope i did it correctly in patch
(sorry for possible inconvenience).
Also marked it as RESEND since it's resend of original patch from 2012 year.

Best regards,
Alexey Klimov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be followed  up by kfree" Alexey Klimov <alexey.klimov@linaro.org> - 2015-09-06 00:50 +0200
  Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be  followed up by kfree" Mark Brown <broonie@kernel.org> - 2015-09-06 02:10 +0200
    Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be  followed up by kfree" Alexey Klimov <klimov.linux@gmail.com> - 2015-09-06 02:30 +0200
      Re: [PATCH RESEND 0/1] Revert "spi/doc: spi_master_put must be  followed up by kfree" Mark Brown <broonie@kernel.org> - 2015-09-07 12:20 +0200

csiph-web