Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1205880 > unrolled thread
| Started by | Markus Pargmann <mpa@pengutronix.de> |
|---|---|
| First post | 2015-08-12 12:20 +0200 |
| Last post | 2015-08-17 09:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 16/20] iio: bmc150: Fix irq checks Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 12:20 +0200
Re: [PATCH 16/20] iio: bmc150: Fix irq checks Jonathan Cameron <jic23@kernel.org> - 2015-08-15 15:20 +0200
Re: [PATCH 16/20] iio: bmc150: Fix irq checks Markus Pargmann <mpa@pengutronix.de> - 2015-08-17 09:30 +0200
| From | Markus Pargmann <mpa@pengutronix.de> |
|---|---|
| Date | 2015-08-12 12:20 +0200 |
| Subject | [PATCH 16/20] iio: bmc150: Fix irq checks |
| Message-ID | <pWBix-1oV-7@gated-at.bofh.it> |
Valid irqs are > 0. This patch fixes the check which fails for the new
spi driver part if no interrupt was given.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/iio/accel/bmc150-accel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
index 4e70f51c2370..fe2d2316158f 100644
--- a/drivers/iio/accel/bmc150-accel.c
+++ b/drivers/iio/accel/bmc150-accel.c
@@ -1660,10 +1660,10 @@ static int bmc150_accel_probe(struct i2c_client *client,
return ret;
}
- if (client->irq < 0)
+ if (client->irq <= 0)
client->irq = bmc150_accel_gpio_probe(client, data);
- if (client->irq >= 0) {
+ if (client->irq > 0) {
ret = devm_request_threaded_irq(
&client->dev, client->irq,
bmc150_accel_irq_handler,
--
2.4.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2015-08-15 15:20 +0200 |
| Message-ID | <pXJxo-2uX-17@gated-at.bofh.it> |
| In reply to | #1205880 |
On 12/08/15 11:12, Markus Pargmann wrote:
> Valid irqs are > 0. This patch fixes the check which fails for the new
> spi driver part if no interrupt was given.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
This one crossed with Octavian's patch that cleaned up all cases of this.
c176becd81843 iio: fix drivers that consider 0 as a valid IRQ in client->irq
Hence you can drop this one from the v2 of this series.
(Its amazing how many times we get multiple patches for the same issue that
has been there for ages in the same week or so!)
Jonathan
> ---
> drivers/iio/accel/bmc150-accel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
> index 4e70f51c2370..fe2d2316158f 100644
> --- a/drivers/iio/accel/bmc150-accel.c
> +++ b/drivers/iio/accel/bmc150-accel.c
> @@ -1660,10 +1660,10 @@ static int bmc150_accel_probe(struct i2c_client *client,
> return ret;
> }
>
> - if (client->irq < 0)
> + if (client->irq <= 0)
> client->irq = bmc150_accel_gpio_probe(client, data);
>
> - if (client->irq >= 0) {
> + if (client->irq > 0) {
> ret = devm_request_threaded_irq(
> &client->dev, client->irq,
> bmc150_accel_irq_handler,
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Markus Pargmann <mpa@pengutronix.de> |
|---|---|
| Date | 2015-08-17 09:30 +0200 |
| Message-ID | <pYn1M-tt-15@gated-at.bofh.it> |
| In reply to | #1208078 |
[Multipart message — attachments visible in raw view] — view raw
On Sat, Aug 15, 2015 at 02:13:14PM +0100, Jonathan Cameron wrote:
> On 12/08/15 11:12, Markus Pargmann wrote:
> > Valid irqs are > 0. This patch fixes the check which fails for the new
> > spi driver part if no interrupt was given.
> >
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> This one crossed with Octavian's patch that cleaned up all cases of this.
> c176becd81843 iio: fix drivers that consider 0 as a valid IRQ in client->irq
>
> Hence you can drop this one from the v2 of this series.
Thanks, didn't notice this. Will drop it.
Best regards,
Markus
>
> (Its amazing how many times we get multiple patches for the same issue that
> has been there for ages in the same week or so!)
>
> Jonathan
> > ---
> > drivers/iio/accel/bmc150-accel.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
> > index 4e70f51c2370..fe2d2316158f 100644
> > --- a/drivers/iio/accel/bmc150-accel.c
> > +++ b/drivers/iio/accel/bmc150-accel.c
> > @@ -1660,10 +1660,10 @@ static int bmc150_accel_probe(struct i2c_client *client,
> > return ret;
> > }
> >
> > - if (client->irq < 0)
> > + if (client->irq <= 0)
> > client->irq = bmc150_accel_gpio_probe(client, data);
> >
> > - if (client->irq >= 0) {
> > + if (client->irq > 0) {
> > ret = devm_request_threaded_irq(
> > &client->dev, client->irq,
> > bmc150_accel_irq_handler,
> >
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web