Groups > linux.kernel > #1208426

Re: [PATCH 16/20] iio: bmc150: Fix irq checks

From	Markus Pargmann <mpa@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 16/20] iio: bmc150: Fix irq checks
Date	2015-08-17 09:30 +0200
Message-ID	<pYn1M-tt-15@gated-at.bofh.it> (permalink)
References	<pWBix-1oV-9@gated-at.bofh.it> <pWBix-1oV-7@gated-at.bofh.it> <pXJxo-2uX-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, Aug 15, 2015 at 02:13:14PM +0100, Jonathan Cameron wrote:
> On 12/08/15 11:12, Markus Pargmann wrote:
> > Valid irqs are > 0. This patch fixes the check which fails for the new
> > spi driver part if no interrupt was given.
> > 
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> This one crossed with Octavian's patch that cleaned up all cases of this.
> c176becd81843 iio: fix drivers that consider 0 as a valid IRQ in client->irq
> 
> Hence you can drop this one from the v2 of this series.

Thanks, didn't notice this. Will drop it.

Best regards,

Markus

> 
> (Its amazing how many times we get multiple patches for the same issue that
> has been there for ages in the same week or so!)
> 
> Jonathan
> > ---
> >  drivers/iio/accel/bmc150-accel.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
> > index 4e70f51c2370..fe2d2316158f 100644
> > --- a/drivers/iio/accel/bmc150-accel.c
> > +++ b/drivers/iio/accel/bmc150-accel.c
> > @@ -1660,10 +1660,10 @@ static int bmc150_accel_probe(struct i2c_client *client,
> >  		return ret;
> >  	}
> >  
> > -	if (client->irq < 0)
> > +	if (client->irq <= 0)
> >  		client->irq = bmc150_accel_gpio_probe(client, data);
> >  
> > -	if (client->irq >= 0) {
> > +	if (client->irq > 0) {
> >  		ret = devm_request_threaded_irq(
> >  						&client->dev, client->irq,
> >  						bmc150_accel_irq_handler,
> > 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 16/20] iio: bmc150: Fix irq checks Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 12:20 +0200
  Re: [PATCH 16/20] iio: bmc150: Fix irq checks Jonathan Cameron <jic23@kernel.org> - 2015-08-15 15:20 +0200
    Re: [PATCH 16/20] iio: bmc150: Fix irq checks Markus Pargmann <mpa@pengutronix.de> - 2015-08-17 09:30 +0200

csiph-web