Groups > linux.kernel > #1205880

[PATCH 16/20] iio: bmc150: Fix irq checks

From	Markus Pargmann <mpa@pengutronix.de>
Newsgroups	linux.kernel
Subject	[PATCH 16/20] iio: bmc150: Fix irq checks
Date	2015-08-12 12:20 +0200
Message-ID	<pWBix-1oV-7@gated-at.bofh.it> (permalink)
References	<pWBix-1oV-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Valid irqs are > 0. This patch fixes the check which fails for the new
spi driver part if no interrupt was given.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 drivers/iio/accel/bmc150-accel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
index 4e70f51c2370..fe2d2316158f 100644
--- a/drivers/iio/accel/bmc150-accel.c
+++ b/drivers/iio/accel/bmc150-accel.c
@@ -1660,10 +1660,10 @@ static int bmc150_accel_probe(struct i2c_client *client,
 		return ret;
 	}
 
-	if (client->irq < 0)
+	if (client->irq <= 0)
 		client->irq = bmc150_accel_gpio_probe(client, data);
 
-	if (client->irq >= 0) {
+	if (client->irq > 0) {
 		ret = devm_request_threaded_irq(
 						&client->dev, client->irq,
 						bmc150_accel_irq_handler,
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 16/20] iio: bmc150: Fix irq checks Markus Pargmann <mpa@pengutronix.de> - 2015-08-12 12:20 +0200
  Re: [PATCH 16/20] iio: bmc150: Fix irq checks Jonathan Cameron <jic23@kernel.org> - 2015-08-15 15:20 +0200
    Re: [PATCH 16/20] iio: bmc150: Fix irq checks Markus Pargmann <mpa@pengutronix.de> - 2015-08-17 09:30 +0200

csiph-web